mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-10 03:19:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

validate: media-descriptor-parser: fix string leak

Browse source 
_set_content() doesn't actually consume @content so the caller is responsible
freeing it.
This commit is contained in:
Guillaume Desmottes 2015-03-23 10:24:21 +01:00
parent d9a13b5563
commit 6e776b8f0f
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
validate/gst/validate/media-descriptor-parser.c
View file

@ -266,13 +266,16 @@ set_xml_path (GstMediaDescriptorParser * parser, const gchar * path,
gchar *content;
GError *err = NULL;
GstMediaDescriptorParserPrivate *priv = parser->priv;
gboolean result;
if (!g_file_get_contents (path, &content, &xmlsize, &err))
goto failed;
priv->xmlpath = g_strdup (path);
return _set_content (parser, content, xmlsize, error);
result = _set_content (parser, content, xmlsize, error);
g_free (content);
return result;
failed:
g_propagate_error (error, err);
@ -379,8 +382,7 @@ gst_media_descriptor_parser_new_from_xml (GstValidateRunner * runner,
parser = g_object_new (GST_TYPE_MEDIA_DESCRIPTOR_PARSER, "validate-runner",
runner, NULL);
if (_set_content (parser, g_strdup (xml), strlen (xml) * sizeof (gchar),
error) == FALSE) {
if (_set_content (parser, xml, strlen (xml) * sizeof (gchar), error) == FALSE) {
g_object_unref (parser);
return NULL;