mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-23 14:36:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "vaapidecode: fix another pad template ref leak" (Holger Kaelberer)

Browse source 
This reverts commit 2f127d6af4.

For gst_element_class_get_pad_template(), no unreferencing is necessary
according to the GStreamer documentation.
This commit is contained in:
Gwenole Beauchesne 2012-03-02 15:03:57 +01:00
parent 63e29adbf5
commit 6c8b052bd3
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gst/vaapi/gstvaapidecode.c
View file

@ -712,7 +712,6 @@ static void
gst_vaapidecode_init(GstVaapiDecode *decode, GstVaapiDecodeClass *klass) gst_vaapidecode_init(GstVaapiDecode *decode, GstVaapiDecodeClass *klass)
{ {
GstElementClass * const element_class = GST_ELEMENT_CLASS(klass); GstElementClass * const element_class = GST_ELEMENT_CLASS(klass);
GstPadTemplate *pad_template;
decode->display = NULL; decode->display = NULL;
decode->decoder = NULL; decode->decoder = NULL;
@ -724,9 +723,10 @@ gst_vaapidecode_init(GstVaapiDecode *decode, GstVaapiDecodeClass *klass)
decode->is_ready = FALSE; decode->is_ready = FALSE;
/* Pad through which data comes in to the element */ /* Pad through which data comes in to the element */
pad_template = gst_element_class_get_pad_template(element_class, "sink"); decode->sinkpad = gst_pad_new_from_template(
decode->sinkpad = gst_pad_new_from_template(pad_template, "sink"); gst_element_class_get_pad_template(element_class, "sink"),
gst_object_unref(pad_template); "sink"
);
decode->sinkpad_caps = NULL; decode->sinkpad_caps = NULL;
gst_pad_set_getcaps_function(decode->sinkpad, gst_vaapidecode_get_caps); gst_pad_set_getcaps_function(decode->sinkpad, gst_vaapidecode_get_caps);
@ -737,9 +737,10 @@ gst_vaapidecode_init(GstVaapiDecode *decode, GstVaapiDecodeClass *klass)
gst_element_add_pad(GST_ELEMENT(decode), decode->sinkpad); gst_element_add_pad(GST_ELEMENT(decode), decode->sinkpad);
/* Pad through which data goes out of the element */ /* Pad through which data goes out of the element */
pad_template = gst_element_class_get_pad_template(element_class, "src"); decode->srcpad = gst_pad_new_from_template(
decode->srcpad = gst_pad_new_from_template(pad_template, "src"); gst_element_class_get_pad_template(element_class, "src"),
gst_object_unref(pad_template); "src"
);
decode->srcpad_caps = NULL; decode->srcpad_caps = NULL;
gst_pad_use_fixed_caps(decode->srcpad); gst_pad_use_fixed_caps(decode->srcpad);