mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 23:06:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "vorbisenc: push an updated segment stop time when we know it"

Browse source 
This reverts commit a16cd5d2a5.

Setting the stop time on the segment breaks reconfiguration, as the
encoder signals an EOS, but we reconfigure it an continue to produce
buffers.

This information  should not be required via the segment downstream
since we already have the sample count being used to generate buffer
durations.

https://bugzilla.gnome.org/show_bug.cgi?id=768763
This commit is contained in:
Arun Raghavan 2016-07-13 18:29:52 +09:00
parent 714e3b9741
commit 6c84f4e743
1 changed files with 0 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
ext/vorbis/gstvorbisenc.c
View file

@ -775,27 +775,6 @@ gst_vorbis_enc_output_buffers (GstVorbisEnc * vorbisenc)
while (vorbis_bitrate_flushpacket (&vorbisenc->vd, &op)) {
GstBuffer *buf;
if (op.e_o_s) {
GstAudioEncoder *enc = GST_AUDIO_ENCODER (vorbisenc);
GstClockTime duration;
GST_DEBUG_OBJECT (vorbisenc, "Got EOS packet from libvorbis");
GST_AUDIO_ENCODER_STREAM_LOCK (enc);
if (!GST_CLOCK_TIME_IS_VALID (enc->output_segment.stop)) {
GST_DEBUG_OBJECT (vorbisenc,
"Output segment has no end time, setting");
duration =
gst_util_uint64_scale (op.granulepos, GST_SECOND,
vorbisenc->frequency);
enc->output_segment.stop = enc->output_segment.start + duration;
GST_DEBUG_OBJECT (enc, "new output segment %" GST_SEGMENT_FORMAT,
&enc->output_segment);
gst_pad_push_event (GST_AUDIO_ENCODER_SRC_PAD (enc),
gst_event_new_segment (&enc->output_segment));
}
GST_AUDIO_ENCODER_STREAM_UNLOCK (enc);
}
GST_LOG_OBJECT (vorbisenc, "pushing out a data packet");
buf =
gst_audio_encoder_allocate_output_buffer (GST_AUDIO_ENCODER