mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-05 15:08:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

bitwriter: Fix a memory leak in reset_and_get_buffer.

Browse source 
We should record the ownership of the data before we reset the bitwriter.
Or we will always dup the buffer data and leak the memory.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1272>
This commit is contained in:
He Junyan 2021-09-19 22:39:09 +08:00 committed by GStreamer Marge Bot
parent 68f6730221
commit 6be57e4247
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
libs/gst/base/gstbitwriter.c
View file

@ -223,15 +223,18 @@ gst_bit_writer_reset_and_get_buffer (GstBitWriter * bitwriter)
GstBuffer *buffer; GstBuffer *buffer;
gpointer data; gpointer data;
gsize size; gsize size;
gboolean owned;
g_return_val_if_fail (bitwriter != NULL, NULL); g_return_val_if_fail (bitwriter != NULL, NULL);
owned = bitwriter->owned;
size = GST_ROUND_UP_8 (bitwriter->bit_size) >> 3; size = GST_ROUND_UP_8 (bitwriter->bit_size) >> 3;
data = gst_bit_writer_reset_and_get_data (bitwriter); data = gst_bit_writer_reset_and_get_data (bitwriter);
/* we cannot rely on buffers allocated externally, thus let's dup /* we cannot rely on buffers allocated externally, thus let's dup
* the data */ * the data */
if (data && !bitwriter->owned) if (data && !owned)
data = g_memdup (data, size); data = g_memdup (data, size);
buffer = gst_buffer_new (); buffer = gst_buffer_new ();