mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 00:36:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtcbin: Retrieve RR stats from internal sources

Browse source 
Check and generate remote reception statistics from the info stored on
internal sources, as they are stored there  when running against newer rtpbin
since MR !7424

This fixes cases where statistics are incomplete when
peers send RR reports from a single remote ssrc, which GStreamer does
when bundling is enabled and other RTP stacks may too.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7425>
This commit is contained in:
Jan Schmidt 2024-08-29 20:50:59 +10:00 committed by GStreamer Marge Bot
parent 80bb69ba66
commit 6b94f22bd6
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c
View file

@ -111,7 +111,7 @@ _get_stats_from_remote_rtp_source_stats (TransportStream * stream,
const gchar * codec_id, const gchar * kind, const gchar * transport_id, const gchar * codec_id, const gchar * kind, const gchar * transport_id,
GstStructure * s) GstStructure * s)
{ {
gboolean have_rb = FALSE, internal = FALSE; gboolean have_rb = FALSE;
int lost; int lost;
GstStructure *r_in; GstStructure *r_in;
gchar *r_in_id, *out_id; gchar *r_in_id, *out_id;
@ -120,11 +120,10 @@ _get_stats_from_remote_rtp_source_stats (TransportStream * stream,
double ts; double ts;
gst_structure_get_double (s, "timestamp", &ts); gst_structure_get_double (s, "timestamp", &ts);
gst_structure_get (source_stats, "internal", G_TYPE_BOOLEAN, &internal, gst_structure_get (source_stats, "have-rb", G_TYPE_BOOLEAN, &have_rb, NULL);
"have-rb", G_TYPE_BOOLEAN, &have_rb, NULL);
/* This isn't what we're looking for */ /* This isn't what we're looking for */
if (internal == TRUE || have_rb == FALSE) if (have_rb == FALSE)
return FALSE; return FALSE;
r_in_id = g_strdup_printf ("rtp-remote-inbound-stream-stats_%u", ssrc); r_in_id = g_strdup_printf ("rtp-remote-inbound-stream-stats_%u", ssrc);
@ -920,7 +919,6 @@ webrtc_stats_get_from_transport_for_one_ssrc (SsrcMapItem * entry,
guint stats_ssrc = 0; guint stats_ssrc = 0;
/* skip foreign sources */
if (gst_structure_get_uint (stats, "ssrc", &stats_ssrc) && if (gst_structure_get_uint (stats, "ssrc", &stats_ssrc) &&
entry->ssrc == stats_ssrc) { entry->ssrc == stats_ssrc) {
GST_TRACE ("Found source stats for ssrc %u: %" GST_PTR_FORMAT, stats_ssrc, GST_TRACE ("Found source stats for ssrc %u: %" GST_PTR_FORMAT, stats_ssrc,
@ -928,7 +926,9 @@ webrtc_stats_get_from_transport_for_one_ssrc (SsrcMapItem * entry,
_get_stats_from_rtp_source_stats (ts_stats->stream, stats, _get_stats_from_rtp_source_stats (ts_stats->stream, stats,
ts_stats->codec_id, ts_stats->kind, ts_stats->transport_id, ts_stats->codec_id, ts_stats->kind, ts_stats->transport_id,
ts_stats->s); ts_stats->s);
} else if (gst_structure_get_uint (stats, "rb-ssrc", &stats_ssrc) }
if (gst_structure_get_uint (stats, "rb-ssrc", &stats_ssrc)
&& entry->ssrc == stats_ssrc) { && entry->ssrc == stats_ssrc) {
GST_TRACE ("Found remote source stats for ssrc %u: %" GST_PTR_FORMAT, GST_TRACE ("Found remote source stats for ssrc %u: %" GST_PTR_FORMAT,
stats_ssrc, stats); stats_ssrc, stats);