mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

gl/upload/meta: remove unneeded texture deletion

Browse source 
The textures are managed by the GstGLMemory inside the output buffer.  Freeing
them prematurely may result in a use-after-free.
This commit is contained in:
Matthew Waters 2016-06-15 14:40:40 +10:00
parent 15a3b0f6ce
commit 6b7f94abb2
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst-libs/gst/gl/gstglupload.c
View file

@ -910,16 +910,9 @@ static void
_upload_meta_upload_free (gpointer impl) _upload_meta_upload_free (gpointer impl)
{ {
struct GLUploadMeta *upload = impl; struct GLUploadMeta *upload = impl;
gint i;
g_return_if_fail (impl != NULL); g_return_if_fail (impl != NULL);
for (i = 0; i < GST_GL_UPLOAD_MAX_PLANES; i++) {
if (upload->texture_ids[i])
gst_gl_context_del_texture (upload->upload->context,
&upload->texture_ids[i]);
}
if (upload->params) if (upload->params)
gst_gl_allocation_params_free ((GstGLAllocationParams *) upload->params); gst_gl_allocation_params_free ((GstGLAllocationParams *) upload->params);