testsuite/gst-lint: Check for non-statically scoped parent_class variables. This won't be a problem once plugins are...

Original commit message from CVS:
* testsuite/gst-lint: Check for non-statically scoped
parent_class variables.  This won't be a problem once
plugins are loaded with RTLD_LOCAL.
This commit is contained in:
David Schleef 2005-02-09 20:50:35 +00:00
parent c3118a7382
commit 6b55d8f1eb
3 changed files with 38 additions and 2 deletions

View file

@ -1,3 +1,9 @@
2005-02-09 David Schleef <ds@schleef.org>
* testsuite/gst-lint: Check for non-statically scoped
parent_class variables. This won't be a problem once
plugins are loaded with RTLD_LOCAL.
2005-02-09 Ronald S. Bultje <rbultje@ronald.bitfreak.net> 2005-02-09 Ronald S. Bultje <rbultje@ronald.bitfreak.net>
* ext/mplex/gstmplexibitstream.cc: * ext/mplex/gstmplexibitstream.cc:

View file

@ -48,6 +48,7 @@ sub check_explicit_caps();
sub check_signals(); sub check_signals();
sub check_gettext(); sub check_gettext();
sub check_padtemplate(); sub check_padtemplate();
sub check_parent_class();
sub m_check_plugindir(); sub m_check_plugindir();
sub m_check_interfaces(); sub m_check_interfaces();
@ -78,6 +79,7 @@ foreach $filename (<FIND>) {
check_signals(); check_signals();
check_gettext(); check_gettext();
check_padtemplate(); check_padtemplate();
check_parent_class();
# less important stuff # less important stuff
check_license(); check_license();
@ -548,7 +550,20 @@ sub check_padtemplate()
{ {
foreach $line (@lines){ foreach $line (@lines){
if ($line =~ /GstStaticPadTemplate/ && !($line =~ /static/)) { if ($line =~ /GstStaticPadTemplate/ && !($line =~ /static/)) {
print "W: pad template definitions should be static\n" print "W: pad template definitions should be static\n";
return;
}
}
}
#
# Check that parent_class is statically scoped
#
sub check_parent_class()
{
foreach $line (@lines){
if ($line =~ /Gst.*\*\s*parent_class/ && !($line =~ /static/)) {
print "E: parent_class definitions should be static\n";
return; return;
} }
} }

View file

@ -48,6 +48,7 @@ sub check_explicit_caps();
sub check_signals(); sub check_signals();
sub check_gettext(); sub check_gettext();
sub check_padtemplate(); sub check_padtemplate();
sub check_parent_class();
sub m_check_plugindir(); sub m_check_plugindir();
sub m_check_interfaces(); sub m_check_interfaces();
@ -78,6 +79,7 @@ foreach $filename (<FIND>) {
check_signals(); check_signals();
check_gettext(); check_gettext();
check_padtemplate(); check_padtemplate();
check_parent_class();
# less important stuff # less important stuff
check_license(); check_license();
@ -548,7 +550,20 @@ sub check_padtemplate()
{ {
foreach $line (@lines){ foreach $line (@lines){
if ($line =~ /GstStaticPadTemplate/ && !($line =~ /static/)) { if ($line =~ /GstStaticPadTemplate/ && !($line =~ /static/)) {
print "W: pad template definitions should be static\n" print "W: pad template definitions should be static\n";
return;
}
}
}
#
# Check that parent_class is statically scoped
#
sub check_parent_class()
{
foreach $line (@lines){
if ($line =~ /Gst.*\*\s*parent_class/ && !($line =~ /static/)) {
print "E: parent_class definitions should be static\n";
return; return;
} }
} }