mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-06 07:28:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

ext/ladspa/: Add some thoughts and FIXME's.

Browse source 
Original commit message from CVS:
* ext/ladspa/gstladspa.c:
* ext/ladspa/gstsignalprocessor.c:
Add some thoughts and FIXME's.
This commit is contained in:
Stefan Kost 2008-03-20 15:54:23 +00:00
parent 7a1019a2b3
commit 6ad41986af
3 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,3 +1,9 @@
2008-03-20 Stefan Kost <ensonic@users.sf.net>
* ext/ladspa/gstladspa.c:
* ext/ladspa/gstsignalprocessor.c:
Add some thoughts and FIXME's.
2008-03-20 Stefan Kost <ensonic@users.sf.net> 2008-03-20 Stefan Kost <ensonic@users.sf.net>
* gst/bayer/gstbayer2rgb.c: * gst/bayer/gstbayer2rgb.c:

9
ext/ladspa/gstladspa.c
View file

@ -89,7 +89,16 @@ gst_ladspa_base_init (gpointer g_class)
if (LADSPA_IS_PORT_AUDIO (p)) { if (LADSPA_IS_PORT_AUDIO (p)) {
gchar *name = g_strdup ((gchar *) desc->PortNames[j]); gchar *name = g_strdup ((gchar *) desc->PortNames[j]);
/* FIXME: group stereo pairs into a stereo pad
* ladspa-fx have "XXX (Left)" and "XXX (Right)"
* where XXX={In,Input,Out,Output}
*/
GST_DEBUG ("LADSPA port name: \"%s\"", name); GST_DEBUG ("LADSPA port name: \"%s\"", name);
/* replaces all spaces with underscores, and then remaining special chars
* with '-'
* FIXME: why, pads can have any name
*/
g_strdelimit (name, " ", '_'); g_strdelimit (name, " ", '_');
g_strcanon (name, G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "_-><=", '-'); g_strcanon (name, G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "_-><=", '-');
GST_DEBUG ("GStreamer pad name: \"%s\"", name); GST_DEBUG ("GStreamer pad name: \"%s\"", name);

4
ext/ladspa/gstsignalprocessor.c
View file

@ -35,7 +35,7 @@
GST_DEBUG_CATEGORY_STATIC (gst_signal_processor_debug); GST_DEBUG_CATEGORY_STATIC (gst_signal_processor_debug);
#define GST_CAT_DEFAULT gst_signal_processor_debug #define GST_CAT_DEFAULT gst_signal_processor_debug
/* FIXME: this is mono only */
static GstStaticCaps template_caps = static GstStaticCaps template_caps =
GST_STATIC_CAPS (GST_AUDIO_FLOAT_STANDARD_PAD_TEMPLATE_CAPS); GST_STATIC_CAPS (GST_AUDIO_FLOAT_STANDARD_PAD_TEMPLATE_CAPS);
@ -71,6 +71,8 @@ gst_signal_processor_pad_template_get_type (void)
return type; return type;
} }
/* FIXME: better allow the caller to pass on the template, right now this can
* only create mono pads */
void void
gst_signal_processor_class_add_pad_template (GstSignalProcessorClass * klass, gst_signal_processor_class_add_pad_template (GstSignalProcessorClass * klass,
const gchar * name, GstPadDirection direction, guint index) const gchar * name, GstPadDirection direction, guint index)