mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-10 17:35:59 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtcbin: Fix trace log 'from' value

Browse source 
`webrtc->signaling_state` (from) and `new_signaling_state` (to) had the
same value when printed in a trace log. This commit adds a
`old_signaling_state` variable to hold the previous value, so that the
print statement works as intented.

Spotted by: Mustafa Asım REYHAN
Fixes #1802

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4362>
This commit is contained in:
Eva Pace 2023-04-06 16:50:23 -03:00 committed by GStreamer Marge Bot
parent 7aaf2b48ef
commit 692d4a3a16
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
View file

@ -6300,6 +6300,7 @@ get_last_generated_description (GstWebRTCBin * webrtc, SDPSource source,
static GstStructure * static GstStructure *
_set_description_task (GstWebRTCBin * webrtc, struct set_description *sd) _set_description_task (GstWebRTCBin * webrtc, struct set_description *sd)
{ {
GstWebRTCSignalingState old_signaling_state = webrtc->signaling_state;
GstWebRTCSignalingState new_signaling_state = webrtc->signaling_state; GstWebRTCSignalingState new_signaling_state = webrtc->signaling_state;
gboolean signalling_state_changed = FALSE; gboolean signalling_state_changed = FALSE;
GError *error = NULL; GError *error = NULL;
@ -6654,7 +6655,7 @@ _set_description_task (GstWebRTCBin * webrtc, struct set_description *sd)
*/ */
if (signalling_state_changed) { if (signalling_state_changed) {
const gchar *from = _enum_value_to_string (GST_TYPE_WEBRTC_SIGNALING_STATE, const gchar *from = _enum_value_to_string (GST_TYPE_WEBRTC_SIGNALING_STATE,
webrtc->signaling_state); old_signaling_state);
const gchar *to = _enum_value_to_string (GST_TYPE_WEBRTC_SIGNALING_STATE, const gchar *to = _enum_value_to_string (GST_TYPE_WEBRTC_SIGNALING_STATE,
new_signaling_state); new_signaling_state);
GST_TRACE_OBJECT (webrtc, "notify signaling-state from %s " GST_TRACE_OBJECT (webrtc, "notify signaling-state from %s "