mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 03:46:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

openh264: Add FIXME comment about missing API in openh264

Browse source
This commit is contained in:
Sebastian Dröge 2014-10-02 16:46:25 +03:00
parent 0e15f47bdf
commit 68baaf19c3
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ext/openh264/gstopenh264dec.cpp
View file

@ -303,6 +303,9 @@ static GstFlowReturn gst_openh264dec_handle_frame(GstVideoDecoder *decoder, GstV
return GST_FLOW_EOS; return GST_FLOW_EOS;
} }
/* FIXME: openh264 has no way for us to get a connection
* between the input and output frames, we just have to
* guess based on the input */
frame = get_oldest_pts_frame (decoder); frame = get_oldest_pts_frame (decoder);
if (!frame) { if (!frame) {
/* Can only happen in finish() */ /* Can only happen in finish() */

3
ext/openh264/gstopenh264enc.cpp
View file

@ -662,6 +662,9 @@ static GstFlowReturn gst_openh264enc_handle_frame(GstVideoEncoder *encoder, GstV
frame = NULL; frame = NULL;
} }
/* FIXME: openh264 has no way for us to get a connection
* between the input and output frames, we just have to
* guess based on the input */
frame = gst_video_encoder_get_oldest_frame(base_encoder); frame = gst_video_encoder_get_oldest_frame(base_encoder);
if (!frame) { if (!frame) {
GST_ELEMENT_ERROR(openh264enc, STREAM, ENCODE, ("Could not encode frame"), ("openh264enc returned %d", ret)); GST_ELEMENT_ERROR(openh264enc, STREAM, ENCODE, ("Could not encode frame"), ("openh264enc returned %d", ret));