mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-09-28 14:52:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtspsrc: Fix regression when using hostname in the location property

Browse source 
When the address can't be parsed as an IP address, it should just be
treated as a hostname and used as-is.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1576

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3596>
This commit is contained in:
Nirbheek Chauhan 2022-11-16 13:33:39 +05:30 committed by Tim-Philipp Müller
parent 0b2db215e9
commit 66ef101cf5
1 changed files with 19 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
subprojects/gst-plugins-good/gst/rtsp/gstrtspsrc.c
View file

@ -4364,25 +4364,29 @@ element_make_from_addr (const GstURIType type, const char *addr_s,
char *uri = NULL;
addr = g_inet_address_new_from_string (addr_s);
switch (g_inet_address_get_family (addr)) {
case G_SOCKET_FAMILY_IPV6:
uri = g_strdup_printf ("udp://[%s]:%i", addr_s, port);
break;
case G_SOCKET_FAMILY_INVALID:
GST_ERROR ("Unknown family type for %s", addr_s);
goto out;
case G_SOCKET_FAMILY_UNIX:
GST_ERROR ("Unexpected family type UNIX for %s", addr_s);
goto out;
case G_SOCKET_FAMILY_IPV4:
uri = g_strdup_printf ("udp://%s:%i", addr_s, port);
break;
if (addr == NULL) {
/* Address is a hostname, not an IP address */
uri = g_strdup_printf ("udp://%s:%i", addr_s, port);
} else {
switch (g_inet_address_get_family (addr)) {
case G_SOCKET_FAMILY_IPV6:
uri = g_strdup_printf ("udp://[%s]:%i", addr_s, port);
break;
case G_SOCKET_FAMILY_INVALID:
GST_ERROR ("Unknown family type for %s", addr_s);
goto out;
case G_SOCKET_FAMILY_UNIX:
GST_ERROR ("Unexpected family type UNIX for %s", addr_s);
goto out;
case G_SOCKET_FAMILY_IPV4:
uri = g_strdup_printf ("udp://%s:%i", addr_s, port);
break;
}
}
element = gst_element_make_from_uri (type, uri, name, error);
out:
g_object_unref (addr);
g_clear_object (&addr);
g_free (uri);
return element;
}