mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-08 08:25:33 +00:00
Code Issues 1 Projects Releases Wiki Activity

qt6glwindow: Only use GL_READ_FRAMEBUFFER when we do blits

Browse source 
This fbo target is not always supported, and should only be used
along with the frame buffer blit extension.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7295>
This commit is contained in:
Nicolas Dufresne 2024-08-01 12:15:17 -04:00 committed by Backport Bot
parent be7ff82614
commit 65f1c70430
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
subprojects/gst-plugins-good/ext/qt6/qt6glwindow.cc
View file

@ -205,6 +205,7 @@ Qt6GLWindow::afterRendering()
guint width, height; guint width, height;
const GstGLFuncs *gl; const GstGLFuncs *gl;
GstGLSyncMeta *sync_meta; GstGLSyncMeta *sync_meta;
GLenum fbo_target;
g_mutex_lock (&this->priv->lock); g_mutex_lock (&this->priv->lock);
@ -220,13 +221,16 @@ Qt6GLWindow::afterRendering()
gst_gl_context_activate (this->priv->other_context, TRUE); gst_gl_context_activate (this->priv->other_context, TRUE);
gl = this->priv->other_context->gl_vtable; gl = this->priv->other_context->gl_vtable;
fbo_target = gl->BlitFramebuffer ? GL_READ_FRAMEBUFFER : GL_FRAMEBUFFER;
if (!this->priv->useDefaultFbo) { if (!this->priv->useDefaultFbo) {
gst_video_frame_unmap (&this->priv->mapped_frame); gst_video_frame_unmap (&this->priv->mapped_frame);
ret = TRUE; ret = TRUE;
} else { } else {
gl->BindFramebuffer (GL_READ_FRAMEBUFFER, 0);
ret = gst_gl_context_check_framebuffer_status (this->priv->other_context, GL_READ_FRAMEBUFFER); gl->BindFramebuffer (fbo_target, 0);
ret = gst_gl_context_check_framebuffer_status (this->priv->other_context, fbo_target);
if (!ret) { if (!ret) {
GST_ERROR ("FBO errors"); GST_ERROR ("FBO errors");
goto errors; goto errors;
@ -254,7 +258,10 @@ Qt6GLWindow::afterRendering()
} }
gst_video_frame_unmap (&this->priv->mapped_frame); gst_video_frame_unmap (&this->priv->mapped_frame);
gl->BindFramebuffer (GL_FRAMEBUFFER, 0); gl->BindFramebuffer (fbo_target, 0);
if (gl->BlitFramebuffer)
gl->BindFramebuffer (GL_DRAW_FRAMEBUFFER, 0);
if (this->priv->context) { if (this->priv->context) {
sync_meta = gst_buffer_get_gl_sync_meta (this->priv->buffer); sync_meta = gst_buffer_get_gl_sync_meta (this->priv->buffer);