mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 11:41:09 +00:00
Code Issues 1 Projects Releases Wiki Activity

meson: Enable some MSVC warnings for parity with GCC/Clang

Browse source 
This makes it easier to do development with MSVC by making it warn
on common issues that GCC/Clang error out for in our CI configuration.

Continuation from https://gitlab.freedesktop.org/gstreamer/gst-build/-/merge_requests/223

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-devtools/-/merge_requests/226>
This commit is contained in:
Nirbheek Chauhan 2020-11-04 18:49:03 +05:30
parent dbf7dbe830
commit 65b09be892
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
meson.build
View file

@ -32,16 +32,23 @@ gst_req = '>= @0@.@1@.0'.format(gst_version_major, gst_version_minor)
cc = meson.get_compiler('c') cc = meson.get_compiler('c')
if cc.get_id() == 'msvc' if cc.get_id() == 'msvc'
# Ignore several spurious warnings for things gstreamer does very commonly msvc_args = [
# If a warning is completely useless and spammy, use '/wdXXXX' to suppress it # Ignore several spurious warnings for things gstreamer does very commonly
# If a warning is harmless but hard to fix, use '/woXXXX' so it's shown once # If a warning is completely useless and spammy, use '/wdXXXX' to suppress it
# NOTE: Only add warnings here if you are sure they're spurious # If a warning is harmless but hard to fix, use '/woXXXX' so it's shown once
add_project_arguments( # NOTE: Only add warnings here if you are sure they're spurious
'/wd4018', # implicit signed/unsigned conversion '/wd4018', # implicit signed/unsigned conversion
'/wd4146', # unary minus on unsigned (beware INT_MIN) '/wd4146', # unary minus on unsigned (beware INT_MIN)
'/wd4244', # lossy type conversion (e.g. double -> int) '/wd4244', # lossy type conversion (e.g. double -> int)
'/wd4305', # truncating type conversion (e.g. double -> float) '/wd4305', # truncating type conversion (e.g. double -> float)
language : 'c') cc.get_supported_arguments(['/utf-8']), # set the input encoding to utf-8
# Enable some warnings on MSVC to match GCC/Clang behaviour
'/w14062', # enumerator 'identifier' in switch of enum 'enumeration' is not handled
'/w14101', # 'identifier' : unreferenced local variable
'/w14189', # 'identifier' : local variable is initialized but not referenced
]
add_project_arguments(msvc_args, language: 'c')
# Disable SAFESEH with MSVC for plugins and libs that use external deps that # Disable SAFESEH with MSVC for plugins and libs that use external deps that
# are built with MinGW # are built with MinGW
noseh_link_args = ['/SAFESEH:NO'] noseh_link_args = ['/SAFESEH:NO']