basesrc, basesink: add some FIXMEs for the type of the blocksize property

This commit is contained in:
Tim-Philipp Müller 2011-01-02 16:58:39 +00:00
parent 7f7721511c
commit 655451db54
2 changed files with 6 additions and 0 deletions

View file

@ -506,6 +506,7 @@ gst_base_sink_class_init (GstBaseSinkClass * klass)
* *
* Since: 0.10.22 * Since: 0.10.22
*/ */
/* FIXME 0.11: blocksize property should be int, otherwise min>max.. */
g_object_class_install_property (gobject_class, PROP_BLOCKSIZE, g_object_class_install_property (gobject_class, PROP_BLOCKSIZE,
g_param_spec_uint ("blocksize", "Block size", g_param_spec_uint ("blocksize", "Block size",
"Size in bytes to pull per buffer (0 = default)", 0, G_MAXUINT, "Size in bytes to pull per buffer (0 = default)", 0, G_MAXUINT,
@ -1244,6 +1245,7 @@ gst_base_sink_get_render_delay (GstBaseSink * sink)
* *
* Since: 0.10.22 * Since: 0.10.22
*/ */
/* FIXME 0.11: blocksize property should be int, otherwise min>max.. */
void void
gst_base_sink_set_blocksize (GstBaseSink * sink, guint blocksize) gst_base_sink_set_blocksize (GstBaseSink * sink, guint blocksize)
{ {
@ -1266,6 +1268,7 @@ gst_base_sink_set_blocksize (GstBaseSink * sink, guint blocksize)
* *
* Since: 0.10.22 * Since: 0.10.22
*/ */
/* FIXME 0.11: blocksize property should be int, otherwise min>max.. */
guint guint
gst_base_sink_get_blocksize (GstBaseSink * sink) gst_base_sink_get_blocksize (GstBaseSink * sink)
{ {

View file

@ -346,6 +346,7 @@ gst_base_src_class_init (GstBaseSrcClass * klass)
gobject_class->set_property = gst_base_src_set_property; gobject_class->set_property = gst_base_src_set_property;
gobject_class->get_property = gst_base_src_get_property; gobject_class->get_property = gst_base_src_get_property;
/* FIXME 0.11: blocksize property should be int, not ulong (min is >max here) */
g_object_class_install_property (gobject_class, PROP_BLOCKSIZE, g_object_class_install_property (gobject_class, PROP_BLOCKSIZE,
g_param_spec_ulong ("blocksize", "Block size", g_param_spec_ulong ("blocksize", "Block size",
"Size in bytes to read per buffer (-1 = default)", 0, G_MAXULONG, "Size in bytes to read per buffer (-1 = default)", 0, G_MAXULONG,
@ -641,6 +642,7 @@ gst_base_src_query_latency (GstBaseSrc * src, gboolean * live,
* *
* Since: 0.10.22 * Since: 0.10.22
*/ */
/* FIXME 0.11: blocksize property should be int, not ulong */
void void
gst_base_src_set_blocksize (GstBaseSrc * src, gulong blocksize) gst_base_src_set_blocksize (GstBaseSrc * src, gulong blocksize)
{ {
@ -661,6 +663,7 @@ gst_base_src_set_blocksize (GstBaseSrc * src, gulong blocksize)
* *
* Since: 0.10.22 * Since: 0.10.22
*/ */
/* FIXME 0.11: blocksize property should be int, not ulong */
gulong gulong
gst_base_src_get_blocksize (GstBaseSrc * src) gst_base_src_get_blocksize (GstBaseSrc * src)
{ {