mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-11 09:55:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

pnmdec: Return early on ::finish() if we have no actual data to parse

Browse source 
Otherwise we'd be working with a NULL buffer and cause various critical
warnings along the way.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1104
This commit is contained in:
Sebastian Dröge 2019-10-22 09:30:34 +03:00 committed by Sebastian Dröge
parent 8969f02fd5
commit 651110de09
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst/pnm/gstpnmdec.c
View file

@ -244,6 +244,9 @@ gst_pnmdec_parse_ascii (GstPnmdec * s, const guint8 * b, guint bs)
GstMapInfo map;
guint8 *outdata;
if (!s->buf)
return GST_FLOW_OK;
target = s->size - s->current_size;
gst_buffer_map (s->buf, &map, GST_MAP_WRITE);
@ -571,7 +574,7 @@ gst_pnmdec_finish (GstVideoDecoder * decoder)
if (s->mngr.info.encoding == GST_PNM_ENCODING_ASCII) {
/* One last go at outputting any final value */
gst_pnmdec_parse_ascii (s, 0, 0);
if (s->size <= s->current_size) {
if (s->size && s->size <= s->current_size) {
return gst_video_decoder_have_frame (decoder);
}
}