mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

Add -Wformat-nonliteral -Wformat-security flags

Browse source 
and fix the warnings
This commit is contained in:
Benjamin Otte 2010-03-22 16:21:31 +01:00
parent 5038a886ab
commit 647cf64c01
2 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
configure.ac
View file

@ -241,12 +241,12 @@ AG_GST_SET_PLUGINDIR
dnl define an ERROR_CFLAGS Makefile variable dnl define an ERROR_CFLAGS Makefile variable
AG_GST_SET_ERROR_CFLAGS($GST_GIT, [ AG_GST_SET_ERROR_CFLAGS($GST_GIT, [
-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef
-Wwrite-strings ]) -Wwrite-strings -Wformat-nonliteral -Wformat-security ])
dnl define an ERROR_CXXFLAGS Makefile variable dnl define an ERROR_CXXFLAGS Makefile variable
AG_GST_SET_ERROR_CXXFLAGS($GST_GIT, [ AG_GST_SET_ERROR_CXXFLAGS($GST_GIT, [
-Wmissing-declarations -Wredundant-decls -Wundef -Wmissing-declarations -Wredundant-decls -Wundef
-Wwrite-strings ]) -Wwrite-strings -Wformat-nonliteral -Wformat-security ])
dnl define correct level for debugging messages dnl define correct level for debugging messages
AG_GST_SET_LEVEL_DEFAULT($GST_GIT) AG_GST_SET_LEVEL_DEFAULT($GST_GIT)

14
gst/mxf/mxfmux.c
View file

@ -376,6 +376,18 @@ gst_mxf_mux_setcaps (GstPad * pad, GstCaps * caps)
return ret; return ret;
} }
static char *
gst_mxf_mux_create_pad_name (GstPadTemplate * templ, guint id)
{
GString *string;
string = g_string_new (GST_PAD_TEMPLATE_NAME_TEMPLATE (templ));
g_string_truncate (string, string->len - 2);
g_string_append_printf (string, "%u", id);
return g_string_free (string, FALSE);
}
static GstPad * static GstPad *
gst_mxf_mux_request_new_pad (GstElement * element, gst_mxf_mux_request_new_pad (GstElement * element,
GstPadTemplate * templ, const gchar * pad_name) GstPadTemplate * templ, const gchar * pad_name)
@ -399,7 +411,7 @@ gst_mxf_mux_request_new_pad (GstElement * element,
} }
pad_number = g_atomic_int_exchange_and_add ((gint *) & mux->n_pads, 1); pad_number = g_atomic_int_exchange_and_add ((gint *) & mux->n_pads, 1);
name = g_strdup_printf (GST_PAD_TEMPLATE_NAME_TEMPLATE (templ), pad_number); name = gst_mxf_mux_create_pad_name (templ, pad_number);
GST_DEBUG_OBJECT (mux, "Creating pad '%s'", name); GST_DEBUG_OBJECT (mux, "Creating pad '%s'", name);
pad = gst_pad_new_from_template (templ, name); pad = gst_pad_new_from_template (templ, name);