mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-30 19:18:31 +00:00
Code Issues 1 Projects Releases Wiki Activity

tracers: leaks: some micro-optimisations

Browse source 
- we know number of filter items is not going to change,
  but compiler doesn't

- only do GST_IS_TRACER check for GObjects, not mini objects

- use non-type check cast macros in performance critical paths
This commit is contained in:
Tim-Philipp Müller 2016-06-03 13:55:44 +01:00
parent 0bb7fa9855
commit 6446a1a45c
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
plugins/tracers/gstleaks.c
View file

@ -79,20 +79,16 @@ set_filtering (GstLeaksTracer * self)
} }
static gboolean static gboolean
should_handle_object (GstLeaksTracer * self, gpointer object, GType object_type) should_handle_object_type (GstLeaksTracer * self, GType object_type)
{ {
guint i; guint i, len;
if (GST_IS_TRACER (object))
/* We can't track tracers as they may be disposed after the leak tracer
* itself */
return FALSE;
if (!self->filter) if (!self->filter)
/* No filtering, handle all types */ /* No filtering, handle all types */
return TRUE; return TRUE;
for (i = 0; i < self->filter->len; i++) { len = self->filter->len;
for (i = 0; i < len; i++) {
GType type = g_array_index (self->filter, GType, i); GType type = g_array_index (self->filter, GType, i);
if (g_type_is_a (object_type, type)) if (g_type_is_a (object_type, type))
@ -126,7 +122,7 @@ static void
handle_object_created (GstLeaksTracer * self, gpointer object, GType type, handle_object_created (GstLeaksTracer * self, gpointer object, GType type,
gboolean gobject) gboolean gobject)
{ {
if (!should_handle_object (self, object, type)) if (!should_handle_object_type (self, type))
return; return;
if (gobject) if (gobject)
@ -144,7 +140,7 @@ static void
mini_object_created_cb (GstTracer * tracer, GstClockTime ts, mini_object_created_cb (GstTracer * tracer, GstClockTime ts,
GstMiniObject * object) GstMiniObject * object)
{ {
GstLeaksTracer *self = GST_LEAKS_TRACER (tracer); GstLeaksTracer *self = GST_LEAKS_TRACER_CAST (tracer);
handle_object_created (self, object, GST_MINI_OBJECT_TYPE (object), FALSE); handle_object_created (self, object, GST_MINI_OBJECT_TYPE (object), FALSE);
} }
@ -152,9 +148,14 @@ mini_object_created_cb (GstTracer * tracer, GstClockTime ts,
static void static void
object_created_cb (GstTracer * tracer, GstClockTime ts, GstObject * object) object_created_cb (GstTracer * tracer, GstClockTime ts, GstObject * object)
{ {
GstLeaksTracer *self = GST_LEAKS_TRACER (tracer); GstLeaksTracer *self = GST_LEAKS_TRACER_CAST (tracer);
GType object_type = G_OBJECT_TYPE (object);
handle_object_created (self, object, G_OBJECT_TYPE (object), TRUE); /* Can't track tracers as they may be disposed after the leak tracer itself */
if (g_type_is_a (object_type, GST_TYPE_TRACER))
return;
handle_object_created (self, object, object_type, TRUE);
} }
static void static void