mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-21 15:56:42 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtspclientsink: Set async-handling=false for the internal bins

Browse source 
Without this we can easily run into a race condition with async state changes:
- the pipeline is doing an async state change
- we set the internal bins to PLAYING but that's ignored because an
  async state change is currently pending
- the async state change finishes but does not change the state of the
  internal bins because of locked_state==TRUE
- the internal bins stay in PAUSED forever
This commit is contained in:
Sebastian Dröge 2019-04-15 20:54:24 +03:00 committed by Sebastian Dröge
parent c4653ef38b
commit 640c5bba41
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gst/rtsp-sink/gstrtspclientsink.c
View file

@ -878,6 +878,7 @@ gst_rtsp_client_sink_init (GstRTSPClientSink * sink)
g_cond_init (&sink->open_conn_cond);
sink->internal_bin = (GstBin *) gst_bin_new ("rtspbin");
g_object_set (sink->internal_bin, "async-handling", TRUE, NULL);
gst_element_set_locked_state (GST_ELEMENT_CAST (sink->internal_bin), TRUE);
gst_bin_add (GST_BIN (sink), GST_ELEMENT_CAST (sink->internal_bin));