mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-11 01:45:33 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/gstelement.c: Use src/sink pads lists for the respective iterators instead of filtering.

Browse source 
Original commit message from CVS:
* gst/gstelement.c: (gst_element_iterate_pad_list),
(gst_element_iterate_pads), (gst_element_iterate_src_pads),
(gst_element_iterate_sink_pads):
Use src/sink pads lists for the respective iterators instead
of filtering.
This commit is contained in:
Wim Taymans 2005-10-10 15:55:37 +00:00
parent ac8289c7a9
commit 63f02ce9ad
2 changed files with 30 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
2005-10-10 Wim Taymans <wim@fluendo.com>
* gst/gstelement.c: (gst_element_iterate_pad_list),
(gst_element_iterate_pads), (gst_element_iterate_src_pads),
(gst_element_iterate_sink_pads):
Use src/sink pads lists for the respective iterators instead
of filtering.
2005-10-10 Andy Wingo <wingo@pobox.com> 2005-10-10 Andy Wingo <wingo@pobox.com>
Merged in popt removal + GOption addition patch from Ronald, bug Merged in popt removal + GOption addition patch from Ronald, bug

54
gst/gstelement.c
View file

@ -925,6 +925,25 @@ iterate_pad (GstIterator * it, GstPad * pad)
return GST_ITERATOR_ITEM_PASS; return GST_ITERATOR_ITEM_PASS;
} }
static GstIterator *
gst_element_iterate_pad_list (GstElement * element, GList ** padlist)
{
GstIterator *result;
GST_LOCK (element);
gst_object_ref (element);
result = gst_iterator_new_list (GST_TYPE_PAD,
GST_GET_LOCK (element),
&element->pads_cookie,
padlist,
element,
(GstIteratorItemFunction) iterate_pad,
(GstIteratorDisposeFunction) gst_object_unref);
GST_UNLOCK (element);
return result;
}
/** /**
* gst_element_iterate_pads: * gst_element_iterate_pads:
* @element: a #GstElement to iterate pads of. * @element: a #GstElement to iterate pads of.
@ -939,36 +958,9 @@ iterate_pad (GstIterator * it, GstPad * pad)
GstIterator * GstIterator *
gst_element_iterate_pads (GstElement * element) gst_element_iterate_pads (GstElement * element)
{ {
GstIterator *result;
g_return_val_if_fail (GST_IS_ELEMENT (element), NULL); g_return_val_if_fail (GST_IS_ELEMENT (element), NULL);
GST_LOCK (element); return gst_element_iterate_pad_list (element, &element->pads);
gst_object_ref (element);
result = gst_iterator_new_list (GST_TYPE_PAD,
GST_GET_LOCK (element),
&element->pads_cookie,
&element->pads,
element,
(GstIteratorItemFunction) iterate_pad,
(GstIteratorDisposeFunction) gst_object_unref);
GST_UNLOCK (element);
return result;
}
static gint
direction_filter (gconstpointer pad, gconstpointer direction)
{
if (GST_PAD_DIRECTION (pad) == GPOINTER_TO_INT (direction)) {
/* pass the ref through */
return 0;
} else {
/* unref */
/* FIXME: this is very stupid */
gst_object_unref (GST_OBJECT_CAST (pad));
return 1;
}
} }
/** /**
@ -986,8 +978,7 @@ gst_element_iterate_src_pads (GstElement * element)
{ {
g_return_val_if_fail (GST_IS_ELEMENT (element), NULL); g_return_val_if_fail (GST_IS_ELEMENT (element), NULL);
return gst_iterator_filter (gst_element_iterate_pads (element), return gst_element_iterate_pad_list (element, &element->srcpads);
direction_filter, GINT_TO_POINTER (GST_PAD_SRC));
} }
/** /**
@ -1005,8 +996,7 @@ gst_element_iterate_sink_pads (GstElement * element)
{ {
g_return_val_if_fail (GST_IS_ELEMENT (element), NULL); g_return_val_if_fail (GST_IS_ELEMENT (element), NULL);
return gst_iterator_filter (gst_element_iterate_pads (element), return gst_element_iterate_pad_list (element, &element->sinkpads);
direction_filter, GINT_TO_POINTER (GST_PAD_SINK));
} }
/** /**