mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-22 16:26:39 +00:00
Code Issues 1 Projects Releases Wiki Activity

glupload: Fix always true compiler warning

Browse source 
There was an if case that was always true. After re-reading the Khronos
spec, this case is actually undefined. It is better to just always ignore
the format.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5410>
This commit is contained in:
Nicolas Dufresne 2023-09-27 17:13:22 +02:00 committed by GStreamer Marge Bot
parent ae7871c019
commit 63da298b84
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c
View file

@ -749,13 +749,10 @@ _append_drm_formats_from_video_format (GstGLContext * context,
&dma_modifiers))
return;
/* No modifier info, we just consider it as linear and external_only. */
/* No modifier info, lets warn and move on */
if (!dma_modifiers) {
if (flags | INCLUDE_EXTERNAL) {
drm_format =
gst_video_dma_drm_fourcc_to_string (fourcc, DRM_FORMAT_MOD_LINEAR);
g_ptr_array_add (drm_formats, drm_format);
}
GST_WARNING_OBJECT (context, "Undefined modifiers list for %"
GST_FOURCC_FORMAT, GST_FOURCC_ARGS (fourcc));
return;
}