mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-18 07:47:17 +00:00
Code Issues 1 Projects Releases Wiki Activity

avcodecmap: Add some more comments about the assumptions in the ffmpeg code about H264/H265/AAC

Browse source
This commit is contained in:
Sebastian Dröge 2020-01-24 16:14:28 +02:00
parent 34b1eb117f
commit 63555e5cc7
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ext/libav/gstavcodecmap.c
View file

@ -1300,6 +1300,9 @@ gst_ffmpeg_codecid_to_caps (enum AVCodecID codec_id,
gst_caps_set_value (caps, "stream-format", &arr);
g_value_unset (&arr);
} else if (context) {
/* FIXME: ffmpeg currently assumes AVC if there is extradata and
* byte-stream otherwise. See for example the MOV or MPEG-TS code.
* ffmpeg does not distinguish the different types of AVC. */
if (context->extradata_size > 0) {
gst_caps_set_simple (caps, "stream-format", G_TYPE_STRING, "avc",
NULL);
@ -1329,8 +1332,10 @@ gst_ffmpeg_codecid_to_caps (enum AVCodecID codec_id,
gst_caps_set_value (caps, "stream-format", &arr);
g_value_unset (&arr);
} else if (context) {
/* FIXME: ffmpeg currently assumes HVC1 if there is extradata and
* byte-stream otherwise. See for example the MOV or MPEG-TS code.
* ffmpeg does not distinguish the different types: HVC1/HEV1/etc. */
if (context->extradata_size > 0) {
/* FIXME: Assume hvc1 */
gst_caps_set_simple (caps, "stream-format", G_TYPE_STRING, "hvc1",
NULL);
} else {
@ -1467,13 +1472,14 @@ gst_ffmpeg_codecid_to_caps (enum AVCodecID codec_id,
gst_caps_set_simple (caps, "mpegversion", G_TYPE_INT, 4,
"base-profile", G_TYPE_STRING, "lc", NULL);
/* FIXME: ffmpeg currently assumes raw if there is extradata and
* ADTS otherwise. See for example the FDK AAC encoder. */
if (context && context->extradata_size > 0) {
gst_caps_set_simple (caps, "stream-format", G_TYPE_STRING, "raw",
NULL);
gst_codec_utils_aac_caps_set_level_and_profile (caps,
context->extradata, context->extradata_size);
} else if (context) {
/* FIXME: Assume adts */
gst_caps_set_simple (caps, "stream-format", G_TYPE_STRING, "adts",
NULL);
}