mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-23 09:04:15 +00:00
Code Issues 1 Projects Releases Wiki Activity

ext/vorbis/vorbisparse.c: Set BOS flag in packet structure to fix 'jump depends on unitialized value' errors in valgr...

Browse source 
Original commit message from CVS:
* ext/vorbis/vorbisparse.c: (gst_vorbis_parse_init),
(vorbis_parse_push_headers), (vorbis_parse_chain):
Set BOS flag in packet structure to fix 'jump depends
on unitialized value' errors in valgrind; various minor
clean-ups.
This commit is contained in:
Tim-Philipp Müller 2006-10-03 10:36:38 +00:00
parent e2a039a53e
commit 623b0b5339
2 changed files with 19 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
2006-10-03 Tim-Philipp Müller <tim at centricular dot net>
* ext/vorbis/vorbisparse.c: (gst_vorbis_parse_init),
(vorbis_parse_push_headers), (vorbis_parse_chain):
Set BOS flag in packet structure to fix 'jump depends
on unitialized value' errors in valgrind; various minor
clean-ups.
2006-09-30 Jan Schmidt <thaytan@mad.scientist.com> 2006-09-30 Jan Schmidt <thaytan@mad.scientist.com>
* gst/playback/gstdecodebin.c: (close_pad_link): * gst/playback/gstdecodebin.c: (close_pad_link):

30
ext/vorbis/vorbisparse.c
View file

@ -67,25 +67,13 @@
GST_DEBUG_CATEGORY_EXTERN (vorbisparse_debug); GST_DEBUG_CATEGORY_EXTERN (vorbisparse_debug);
#define GST_CAT_DEFAULT vorbisparse_debug #define GST_CAT_DEFAULT vorbisparse_debug
static GstElementDetails vorbis_parse_details = { static const GstElementDetails vorbis_parse_details = {
"VorbisParse", "VorbisParse",
"Codec/Parser/Audio", "Codec/Parser/Audio",
"parse raw vorbis streams", "parse raw vorbis streams",
"Thomas Vander Stichele <thomas at apestaart dot org>" "Thomas Vander Stichele <thomas at apestaart dot org>"
}; };
/* Filter signals and args */
enum
{
/* FILL ME */
LAST_SIGNAL
};
enum
{
ARG_0
};
static GstStaticPadTemplate vorbis_parse_sink_factory = static GstStaticPadTemplate vorbis_parse_sink_factory =
GST_STATIC_PAD_TEMPLATE ("sink", GST_STATIC_PAD_TEMPLATE ("sink",
GST_PAD_SINK, GST_PAD_SINK,
@ -137,13 +125,16 @@ gst_vorbis_parse_init (GstVorbisParse * parse, GstVorbisParseClass * g_class)
{ {
parse->sinkpad = parse->sinkpad =
gst_pad_new_from_static_template (&vorbis_parse_sink_factory, "sink"); gst_pad_new_from_static_template (&vorbis_parse_sink_factory, "sink");
gst_pad_set_chain_function (parse->sinkpad, vorbis_parse_chain); gst_pad_set_chain_function (parse->sinkpad,
gst_pad_set_event_function (parse->sinkpad, vorbis_parse_sink_event); GST_DEBUG_FUNCPTR (vorbis_parse_chain));
gst_pad_set_event_function (parse->sinkpad,
GST_DEBUG_FUNCPTR (vorbis_parse_sink_event));
gst_element_add_pad (GST_ELEMENT (parse), parse->sinkpad); gst_element_add_pad (GST_ELEMENT (parse), parse->sinkpad);
parse->srcpad = parse->srcpad =
gst_pad_new_from_static_template (&vorbis_parse_src_factory, "src"); gst_pad_new_from_static_template (&vorbis_parse_src_factory, "src");
gst_pad_set_query_function (parse->srcpad, vorbis_parse_src_query); gst_pad_set_query_function (parse->srcpad,
GST_DEBUG_FUNCPTR (vorbis_parse_src_query));
gst_element_add_pad (GST_ELEMENT (parse), parse->srcpad); gst_element_add_pad (GST_ELEMENT (parse), parse->srcpad);
} }
@ -223,6 +214,7 @@ vorbis_parse_push_headers (GstVorbisParse * parse)
packet.granulepos = GST_BUFFER_OFFSET_END (outbuf); packet.granulepos = GST_BUFFER_OFFSET_END (outbuf);
packet.packetno = 1; packet.packetno = 1;
packet.e_o_s = 0; packet.e_o_s = 0;
packet.b_o_s = 1;
vorbis_synthesis_headerin (&parse->vi, &parse->vc, &packet); vorbis_synthesis_headerin (&parse->vi, &parse->vc, &packet);
parse->sample_rate = parse->vi.rate; parse->sample_rate = parse->vi.rate;
outbuf1 = outbuf; outbuf1 = outbuf;
@ -233,6 +225,7 @@ vorbis_parse_push_headers (GstVorbisParse * parse)
packet.granulepos = GST_BUFFER_OFFSET_END (outbuf); packet.granulepos = GST_BUFFER_OFFSET_END (outbuf);
packet.packetno = 2; packet.packetno = 2;
packet.e_o_s = 0; packet.e_o_s = 0;
packet.b_o_s = 0;
vorbis_synthesis_headerin (&parse->vi, &parse->vc, &packet); vorbis_synthesis_headerin (&parse->vi, &parse->vc, &packet);
outbuf2 = outbuf; outbuf2 = outbuf;
@ -242,6 +235,7 @@ vorbis_parse_push_headers (GstVorbisParse * parse)
packet.granulepos = GST_BUFFER_OFFSET_END (outbuf); packet.granulepos = GST_BUFFER_OFFSET_END (outbuf);
packet.packetno = 3; packet.packetno = 3;
packet.e_o_s = 0; packet.e_o_s = 0;
packet.b_o_s = 0;
vorbis_synthesis_headerin (&parse->vi, &parse->vc, &packet); vorbis_synthesis_headerin (&parse->vi, &parse->vc, &packet);
outbuf3 = outbuf; outbuf3 = outbuf;
@ -407,7 +401,7 @@ vorbis_parse_chain (GstPad * pad, GstBuffer * buffer)
GstBuffer *buf; GstBuffer *buf;
GstVorbisParse *parse; GstVorbisParse *parse;
parse = GST_VORBIS_PARSE (gst_pad_get_parent (pad)); parse = GST_VORBIS_PARSE (GST_PAD_PARENT (pad));
buf = GST_BUFFER (buffer); buf = GST_BUFFER (buffer);
parse->packetno++; parse->packetno++;
@ -424,8 +418,6 @@ vorbis_parse_chain (GstPad * pad, GstBuffer * buffer)
ret = vorbis_parse_queue_buffer (parse, buf); ret = vorbis_parse_queue_buffer (parse, buf);
} }
gst_object_unref (parse);
return ret; return ret;
} }