mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "decodebin2: fix deadlock on chain shutdown"

Browse source 
This reverts commit 77dc09c3a9.

It can cause the FLUSH_START/STOP events to go to the sink elements, which
then causes state changes and various other problems. We shouldn't really
flush downstream here, the idea is to do *draining*.

Apart from that the testcase for the original bug here works without this
commit now.
This commit is contained in:
Sebastian Dröge 2015-12-16 17:07:54 +01:00
parent 29cfb9a6d7
commit 60bad4815d
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst/playback/gstdecodebin2.c
View file

@ -3432,10 +3432,8 @@ gst_decode_chain_free_internal (GstDecodeChain * chain, gboolean hide)
if (chain->endpad) { if (chain->endpad) {
if (chain->endpad->exposed) { if (chain->endpad->exposed) {
GstPad *endpad = GST_PAD_CAST (chain->endpad); gst_element_remove_pad (GST_ELEMENT_CAST (chain->dbin),
gst_pad_push_event (endpad, gst_event_new_flush_start ()); GST_PAD_CAST (chain->endpad));
gst_pad_push_event (endpad, gst_event_new_flush_stop (FALSE));
gst_element_remove_pad (GST_ELEMENT_CAST (chain->dbin), endpad);
} }
decode_pad_set_target (chain->endpad, NULL); decode_pad_set_target (chain->endpad, NULL);