mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-04 13:45:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

xml-formatter: Write xml directly to file

Browse source 
Skip allocation of temp buffer (which was undersized).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/250>
This commit is contained in:
Doug Nazar 2021-05-12 17:43:46 -04:00
parent 294ad1d564
commit 60856d5a6f
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ges/ges-xml-formatter.c
View file

@ -953,7 +953,6 @@ _save_subproject_data (GESXmlFormatter * self, SubprojectData * subproj_data,
gint line = 1, i;
gboolean res = FALSE;
gsize start = 0, end = 0;
gchar *subproject_content = NULL;
gchar *xml = GES_BASE_XML_FORMATTER (self)->xmlcontent;
for (i = 0; xml[i] != '\0'; i++) {
@ -973,17 +972,12 @@ _save_subproject_data (GESXmlFormatter * self, SubprojectData * subproj_data,
g_assert (start && end);
size = (end - start);
subproject_content = g_malloc (sizeof (gchar) * size);
memcpy (subproject_content, &xml[start], end - start);
subproject_content[end - start] = '\0';
GST_INFO_OBJECT (self, "Saving subproject %s from %d:%d(%" G_GSIZE_FORMAT
") to %d:%d(%" G_GSIZE_FORMAT ")",
subproj_data->id, subproj_data->start_line, subproj_data->start_char,
start, subproject_end_line, subproject_end_char, end);
res = g_file_set_contents (subproj_data->filename, subproject_content, -1,
error);
g_free (subproject_content);
res = g_file_set_contents (subproj_data->filename, &xml[start], size, error);
return res;
}