mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 14:56:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

multiqueue: add FIXME for wrong code

Browse source 
Needs further investigation
This commit is contained in:
Wim Taymans 2009-10-22 09:41:52 -04:00 committed by Wim Taymans
parent 354cf53f81
commit 6082b0bc89
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
plugins/elements/gstmultiqueue.c
View file

@ -1359,7 +1359,15 @@ single_queue_overrun_cb (GstDataQueue * dq, GstSingleQueue * sq)
G_GUINT64_FORMAT, oq->id, ssize.visible, oq->max_size.visible, G_GUINT64_FORMAT, oq->id, ssize.visible, oq->max_size.visible,
ssize.bytes, oq->max_size.bytes, oq->cur_time, oq->max_size.time); ssize.bytes, oq->max_size.bytes, oq->cur_time, oq->max_size.time);
/* if this queue is filled completely we must signal overrun */ /* if this queue is filled completely we must signal overrun.
* FIXME, this seems wrong in many ways
* - we're comparing the filled level of this queue against the
* values of the other one
* - we should only do this after we found no empty queues, ie, move
* this check outside of the loop
* - the debug statement talks about a different queue than the one
* we are checking here.
*/
if (sq->is_eos || IS_FILLED (sq, bytes, ssize.bytes) || if (sq->is_eos || IS_FILLED (sq, bytes, ssize.bytes) ||
IS_FILLED (sq, time, sq->cur_time)) { IS_FILLED (sq, time, sq->cur_time)) {
GST_LOG_OBJECT (mq, "Queue %d is filled", oq->id); GST_LOG_OBJECT (mq, "Queue %d is filled", oq->id);