mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-03 05:59:10 +00:00
Code Issues 1 Projects Releases Wiki Activity

ext/libpng/gstpngdec.c: Remove endianness-flipping hack that seems to have been required only because of a bug in ffm...

Browse source 
Original commit message from CVS:
* ext/libpng/gstpngdec.c: (gst_pngdec_caps_create_and_set):
Remove endianness-flipping hack that seems to have been required
only because of a bug in ffmpegcolorspace.
Partially Fixes: #451908
This commit is contained in:
Jan Schmidt 2007-07-06 11:42:53 +00:00
parent d13ee0dff1
commit 5e32a710d7
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ChangeLog
View file

@ -1,3 +1,10 @@
2007-07-06 Jan Schmidt <thaytan@mad.scientist.com>
* ext/libpng/gstpngdec.c: (gst_pngdec_caps_create_and_set):
Remove endianness-flipping hack that seems to have been required
only because of a bug in ffmpegcolorspace.
Partially Fixes: #451908
2007-07-05 Stefan Kost <ensonic@users.sf.net> 2007-07-05 Stefan Kost <ensonic@users.sf.net>
* docs/plugins/Makefile.am: * docs/plugins/Makefile.am:

7
ext/libpng/gstpngdec.c
View file

@ -357,9 +357,14 @@ gst_pngdec_caps_create_and_set (GstPngDec * pngdec)
/* Get Color type */ /* Get Color type */
color_type = png_get_color_type (pngdec->png, pngdec->info); color_type = png_get_color_type (pngdec->png, pngdec->info);
/* HACK: The doc states that it's RGBA but apparently it's not... */ #if 0
/* We used to have this HACK to reverse the outgoing bytes, but the problem
* that originally required the hack seems to have been in ffmpegcolorspace's
* RGBA descriptions. It doesn't seem needed now that's fixed, but might
* still be needed on big-endian systems, I'm not sure. J.S. 6/7/2007 */
if (color_type == PNG_COLOR_TYPE_RGB_ALPHA) if (color_type == PNG_COLOR_TYPE_RGB_ALPHA)
png_set_bgr (pngdec->png); png_set_bgr (pngdec->png);
#endif
/* Gray scale converted to RGB and upscaled to 8 bits */ /* Gray scale converted to RGB and upscaled to 8 bits */
if ((color_type == PNG_COLOR_TYPE_GRAY_ALPHA) || if ((color_type == PNG_COLOR_TYPE_GRAY_ALPHA) ||