mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-22 00:06:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: info: Fix spurious validation

Browse source 
Should be equality check, not assignment.
Additionally, use fail_unless_equals_* macro for better readability
and debugging easier, if possible.
This commit is contained in:
Seungha Yang 2019-01-23 12:15:13 +09:00
parent 59c31d8d0f
commit 5b19d30d24
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/check/gst/gstinfo.c
View file

@ -223,7 +223,7 @@ GST_START_TEST (info_log_handler)
guint removed; guint removed;
removed = gst_debug_remove_log_function (gst_debug_log_default); removed = gst_debug_remove_log_function (gst_debug_log_default);
fail_unless (removed == 1); fail_unless_equals_int (removed, 1);
} }
GST_END_TEST; GST_END_TEST;
@ -369,8 +369,8 @@ GST_START_TEST (info_set_and_unset_single)
cat2 = gst_debug_category_get_threshold (states); cat2 = gst_debug_category_get_threshold (states);
gst_debug_set_default_threshold (orig); gst_debug_set_default_threshold (orig);
fail_unless (cat1 = GST_LEVEL_DEBUG); fail_unless_equals_int (cat1, GST_LEVEL_DEBUG);
fail_unless (cat2 = GST_LEVEL_WARNING); fail_unless_equals_int (cat2, GST_LEVEL_WARNING);
} }
GST_END_TEST; GST_END_TEST;
@ -399,9 +399,9 @@ GST_START_TEST (info_set_and_unset_multiple)
gst_debug_set_default_threshold (orig); gst_debug_set_default_threshold (orig);
fail_unless (cat1 = GST_LEVEL_DEBUG); fail_unless_equals_int (cat1, GST_LEVEL_DEBUG);
fail_unless (cat2 = GST_LEVEL_WARNING); fail_unless_equals_int (cat2, GST_LEVEL_WARNING);
fail_unless (cat3 = GST_LEVEL_WARNING); fail_unless_equals_int (cat3, GST_LEVEL_WARNING);
} }
GST_END_TEST; GST_END_TEST;