mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: fix vorbisdec test

Browse source 
There won't be a tag messages on the bus, because tags
are now sent downstream for sinks to post on the bus,
and there's no sink involved here that would do that.
Secondly, the audio decoder base class only sends the
tags out once it has received some non-header data as
input, which is not something we're providing here.
This commit is contained in:
Tim-Philipp Müller 2012-08-09 00:54:30 +01:00
parent 7bdcb12b41
commit 5adc87c6bd
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/check/elements/vorbisdec.c
View file

@ -101,10 +101,9 @@ GST_START_TEST (test_identification_header)
GstBuffer *inbuffer; GstBuffer *inbuffer;
GstBus *bus; GstBus *bus;
GstMessage *message; GstMessage *message;
GstTagList *tag_list;
gchar *artist;
vorbisdec = setup_vorbisdec (); vorbisdec = setup_vorbisdec ();
fail_unless (gst_element_set_state (vorbisdec, fail_unless (gst_element_set_state (vorbisdec,
GST_STATE_PLAYING) == GST_STATE_CHANGE_SUCCESS, GST_STATE_PLAYING) == GST_STATE_CHANGE_SUCCESS,
"could not set to playing"); "could not set to playing");
@ -135,6 +134,8 @@ GST_START_TEST (test_identification_header)
ASSERT_BUFFER_REFCOUNT (inbuffer, "inbuffer", 1); ASSERT_BUFFER_REFCOUNT (inbuffer, "inbuffer", 1);
gst_buffer_unref (inbuffer); gst_buffer_unref (inbuffer);
fail_unless (g_list_length (buffers) == 0); fail_unless (g_list_length (buffers) == 0);
#if 0
/* there's a tag message waiting */ /* there's a tag message waiting */
fail_if ((message = gst_bus_pop (bus)) == NULL); fail_if ((message = gst_bus_pop (bus)) == NULL);
gst_message_parse_tag (message, &tag_list); gst_message_parse_tag (message, &tag_list);
@ -146,6 +147,11 @@ GST_START_TEST (test_identification_header)
fail_unless_equals_int (gst_tag_list_get_tag_size (tag_list, "album"), 0); fail_unless_equals_int (gst_tag_list_get_tag_size (tag_list, "album"), 0);
gst_tag_list_free (tag_list); gst_tag_list_free (tag_list);
gst_message_unref (message); gst_message_unref (message);
#endif
/* make sure there's no error on the bus */
message = gst_bus_pop_filtered (bus, GST_MESSAGE_ERROR);
fail_if (message != NULL);
/* cleanup */ /* cleanup */
gst_bus_set_flushing (bus, TRUE); gst_bus_set_flushing (bus, TRUE);