mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

query: gst_query_add_buffering_range() optimisations

Browse source 
Don't create a new GValueArray copy for every single _add_buffering_range()
call, but append to the existing value array owned by the structure instead.
This commit is contained in:
Tim-Philipp Müller 2010-09-16 00:30:14 +01:00
parent 608628d10d
commit 58e5d5e5b9
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gst/gstquery.c
View file

@ -1321,19 +1321,26 @@ gst_query_add_buffering_range (GstQuery * query, gint64 start, gint64 stop)
if (start > gst_value_get_int64_range_min (last_array_value)) if (start > gst_value_get_int64_range_min (last_array_value))
ret = TRUE; ret = TRUE;
} else { } else {
GValue new_array_val = { 0, };
array = g_value_array_new (0); array = g_value_array_new (0);
g_value_init (&new_array_val, G_TYPE_VALUE_ARRAY);
g_value_take_boxed (&new_array_val, array);
/* set the value array only once, so we then modify (append to) the
* existing value array owned by the GstStructure / the field's GValue */
gst_structure_id_take_value (structure, GST_QUARK (BUFFERING_RANGES),
&new_array_val);
ret = TRUE; ret = TRUE;
} }
if (ret) { if (ret) {
g_value_array_append (array, &range_value); g_value_array_append (array, &range_value);
gst_structure_id_set (structure, GST_QUARK (BUFFERING_RANGES),
G_TYPE_VALUE_ARRAY, array, NULL);
} }
g_value_unset (&range_value); g_value_unset (&range_value);
if (!value)
g_value_array_free (array);
return ret; return ret;
} }