mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-05 02:02:26 +00:00
Code Issues 1 Projects Releases Wiki Activity

gl: Don't steal callers reference when setting non-floating elements via properties

Browse source 
Introduced by fbef9220d3. The code there
is only correct for elements we get from signals.
This commit is contained in:
Sebastian Dröge 2018-07-25 14:23:36 +03:00
parent ab2548d78d
commit 58ac815eae
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/gl/gstglfilterbin.c
View file

@ -245,7 +245,7 @@ gst_gl_filter_bin_set_property (GObject * object, guint prop_id,
switch (prop_id) {
case PROP_FILTER:
gst_gl_filter_bin_set_filter (self, g_value_get_object (value));
gst_gl_filter_bin_set_filter (self, g_value_dup_object (value));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);

2
ext/gl/gstglmixerbin.c
View file

@ -473,7 +473,7 @@ gst_gl_mixer_bin_set_property (GObject * object,
switch (prop_id) {
case PROP_MIXER:
{
GstElement *mixer = g_value_get_object (value);
GstElement *mixer = g_value_dup_object (value);
/* FIXME: deal with replacing a mixer */
g_return_if_fail (!self->mixer || (self->mixer == mixer));
gst_gl_mixer_bin_set_mixer (self, mixer);

2
ext/gl/gstglsinkbin.c
View file

@ -347,7 +347,7 @@ gst_gl_sink_bin_set_property (GObject * object, guint prop_id,
switch (prop_id) {
case PROP_SINK:
gst_gl_sink_bin_set_sink (self, g_value_get_object (value));
gst_gl_sink_bin_set_sink (self, g_value_dup_object (value));
break;
case PROP_CONTRAST:
case PROP_BRIGHTNESS:

2
ext/gl/gstglsrcbin.c
View file

@ -221,7 +221,7 @@ gst_gl_src_bin_set_property (GObject * object, guint prop_id,
switch (prop_id) {
case PROP_SRC:
gst_gl_src_bin_set_src (self, g_value_get_object (value));
gst_gl_src_bin_set_src (self, g_value_dup_object (value));
break;
default:
if (self->src)