mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 08:46:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

urisourcebin: Error out if a source doesn't expose pads

Browse source 
Looks like this fell through the cracks. If a source element doesn't have
dynamic pads and doesn't provide any source pad ... we should properly error
out.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2784>
This commit is contained in:
Edward Hervey 2022-10-19 11:00:09 +02:00 committed by GStreamer Marge Bot
parent 3305d7ce8d
commit 586ec1a672
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
subprojects/gst-plugins-base/gst/playback/gsturisourcebin.c
View file

@ -2320,12 +2320,10 @@ setup_source (GstURISourceBin * urisrc)
/* source provides raw data, we added the pads and we can now signal a /* source provides raw data, we added the pads and we can now signal a
* no_more pads because we are done. */ * no_more pads because we are done. */
gst_element_no_more_pads (GST_ELEMENT_CAST (urisrc)); gst_element_no_more_pads (GST_ELEMENT_CAST (urisrc));
return TRUE;
} else if (!have_out) {
GST_DEBUG_OBJECT (urisrc, "Source has no output pads");
return TRUE; return TRUE;
} }
if (!have_out)
goto no_pads;
} else { } else {
GST_DEBUG_OBJECT (urisrc, "Source has dynamic output pads"); GST_DEBUG_OBJECT (urisrc, "Source has dynamic output pads");
/* connect a handler for the new-pad signal */ /* connect a handler for the new-pad signal */
@ -2392,6 +2390,12 @@ invalid_source:
(_("Source element is invalid.")), (NULL)); (_("Source element is invalid.")), (NULL));
return FALSE; return FALSE;
} }
no_pads:
{
GST_ELEMENT_ERROR (urisrc, CORE, FAILED,
(_("Source element has no pads.")), (NULL));
return FALSE;
}
streaming_failed: streaming_failed:
{ {
/* message was posted */ /* message was posted */