mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 16:08:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

urisourcebin: Use a non-buffering multiqueue for non-streamable URI

Browse source 
Even though buffering is not required, we need to ensure we are dealing with the
interleave (if any) before pushing the elementary streams further downstream.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2784>
This commit is contained in:
Edward Hervey 2022-11-14 14:17:25 +01:00 committed by GStreamer Marge Bot
parent c59397354c
commit 5702568a7e
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
subprojects/gst-plugins-base/gst/playback/gsturisourcebin.c
View file

@ -1048,7 +1048,7 @@ static void
setup_multiqueue (GstURISourceBin * urisrc, ChildSrcPadInfo * info, setup_multiqueue (GstURISourceBin * urisrc, ChildSrcPadInfo * info,
GstElement * multiqueue) GstElement * multiqueue)
{ {
if (info->use_downloadbuffer) { if (info->use_downloadbuffer || !urisrc->is_stream) {
/* If we have a downloadbuffer we will let that one deal with buffering, /* If we have a downloadbuffer we will let that one deal with buffering,
and we only use multiqueue for dealing with interleave */ and we only use multiqueue for dealing with interleave */
g_object_set (info->multiqueue, "use-buffering", FALSE, NULL); g_object_set (info->multiqueue, "use-buffering", FALSE, NULL);
@ -1092,12 +1092,13 @@ new_output_slot (ChildSrcPadInfo * info, GstPad * originating_pad)
/* If a demuxer/parsebin is present, then the downloadbuffer will have been handled before that */ /* If a demuxer/parsebin is present, then the downloadbuffer will have been handled before that */
use_downloadbuffer = info->use_downloadbuffer && !info->demuxer; use_downloadbuffer = info->use_downloadbuffer && !info->demuxer;
/* If parsebin is used and buffering is required, we go through a multiqueue */ /* If parsebin is used, we might have to go through a multiqueue */
if (urisrc->parse_streams && (info->use_queue2 || info->use_downloadbuffer)) { if (urisrc->parse_streams && (info->use_queue2 || info->use_downloadbuffer
|| !urisrc->is_stream)) {
GST_DEBUG_OBJECT (urisrc, "Using multiqueue"); GST_DEBUG_OBJECT (urisrc, "Using multiqueue");
if (!info->multiqueue) { if (!info->multiqueue) {
GST_DEBUG_OBJECT (urisrc, GST_DEBUG_OBJECT (urisrc,
"Creating multiqueue for buffering elementary streams"); "Creating multiqueue for handling elementary streams");
elem_name = "multiqueue"; elem_name = "multiqueue";
info->multiqueue = gst_element_factory_make (elem_name, NULL); info->multiqueue = gst_element_factory_make (elem_name, NULL);
if (!info->multiqueue) if (!info->multiqueue)