decodebin: Include codec description for missing plugins in the error message

If we had plugins and an error occurred we only include the error message
caused by this, otherwise we will include the codec description as generated
from the caps.

This allows to detect which exact codec was missing instead of getting a
generic "no suitable decoders found" error message.
This commit is contained in:
Sebastian Dröge 2014-09-02 12:59:18 +03:00
parent 2157497405
commit 56899b596e

View file

@ -4316,6 +4316,11 @@ gst_decode_chain_expose (GstDecodeChain * chain, GList ** endpads,
if (chain->deadend_details) { if (chain->deadend_details) {
g_string_append (missing_plugin_details, chain->deadend_details); g_string_append (missing_plugin_details, chain->deadend_details);
g_string_append_c (missing_plugin_details, '\n'); g_string_append_c (missing_plugin_details, '\n');
} else {
gchar *desc = gst_pb_utils_get_codec_description (chain->endcaps);
g_string_append_printf (missing_plugin_details, "Missing decoder: %s\n",
desc);
g_free (desc);
} }
*missing_plugin = TRUE; *missing_plugin = TRUE;
} }