mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

decodebin: fix deadlock when resetting buffering

Browse source 
This function is static, and only ever called with the expose lock
taken. It thus has no reason to take this lock itself.

This was introduced by one of my locking fixes from 741355.

https://bugzilla.gnome.org/show_bug.cgi?id=741355
This commit is contained in:
Vincent Penquerc'h 2015-02-24 16:06:08 +00:00
parent 0b0c667e57
commit 561ddabd97
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/playback/gstdecodebin2.c
View file

@ -3062,13 +3062,11 @@ gst_decode_bin_reset_buffering (GstDecodeBin * dbin)
return; return;
GST_DEBUG_OBJECT (dbin, "Reseting multiqueues buffering"); GST_DEBUG_OBJECT (dbin, "Reseting multiqueues buffering");
EXPOSE_LOCK (dbin);
if (dbin->decode_chain) { if (dbin->decode_chain) {
CHAIN_MUTEX_LOCK (dbin->decode_chain); CHAIN_MUTEX_LOCK (dbin->decode_chain);
gst_decode_chain_reset_buffering (dbin->decode_chain); gst_decode_chain_reset_buffering (dbin->decode_chain);
CHAIN_MUTEX_UNLOCK (dbin->decode_chain); CHAIN_MUTEX_UNLOCK (dbin->decode_chain);
} }
EXPOSE_UNLOCK (dbin);
} }
/**** /****