mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-20 06:08:14 +00:00
Code Issues 1 Projects Releases Wiki Activity

d3d11: Disable packed and subsampled YUV formats

Browse source 
Direct3D11 sampler doesn't support them very well, and conversion
outputs usually result in poor visual quality with our shader code.
Should disable support for such formats for now

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2344>
This commit is contained in:
Seungha Yang 2021-06-21 00:19:17 +09:00
parent 0f8631c476
commit 554855f87f
3 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
gst-libs/gst/d3d11/gstd3d11device.cpp
View file

@ -95,7 +95,7 @@ enum
#define DEFAULT_ADAPTER 0
#define DEFAULT_CREATE_FLAGS 0
#define GST_D3D11_N_FORMATS 29
#define GST_D3D11_N_FORMATS 25
struct _GstD3D11DevicePrivate
{
@ -547,6 +547,20 @@ gst_d3d11_device_setup_format_table (GstD3D11Device * self)
priv->format_table[n_formats].dxgi_format = DXGI_FORMAT_UNKNOWN;
n_formats++;
/* FIXME: d3d11 sampler doesn't support packed-and-subsampled formats
* very well (and it's really poorly documented).
* As per observation, d3d11 samplers seems to be dropping the second
* Y componet from "Y0-U0-Y1-V0" pair which results in bad visual quality
* than 4:2:0 subsampled formats. We should revisit this later */
/* TODO: The best would be using d3d11 compute shader to handle this kinds of
* samples but comute shader is not implemented yet by us.
*
* Another simple approach is using d3d11 video processor,
* but capability will be very device dependent because it depends on
* GPU vendor's driver implementation, moreover, software fallback does
* not support d3d11 video processor. So it's not reliable in this case */
#if 0
/* NOTE: packted yuv 4:2:2 YUY2, UYVY, and VYUY formats are not natively
* supported render target view formats
* (i.e., cannot be output format of shader pipeline) */
@ -586,6 +600,7 @@ gst_d3d11_device_setup_format_table (GstD3D11Device * self)
else
priv->format_table[n_formats].dxgi_format = DXGI_FORMAT_UNKNOWN;
n_formats++;
#endif
priv->format_table[n_formats].format = GST_VIDEO_FORMAT_Y410;
priv->format_table[n_formats].resource_format[0] =

2
gst-libs/gst/d3d11/gstd3d11format.h
View file

@ -33,7 +33,7 @@ G_BEGIN_DECLS
"GRAY8, GRAY16_LE"
#define GST_D3D11_EXTRA_IN_FORMATS \
"YUY2, UYVY, VYUY, Y210, Y410"
"Y410"
#define GST_D3D11_SINK_FORMATS \
"{ " GST_D3D11_COMMON_FORMATS " ," GST_D3D11_EXTRA_IN_FORMATS " }"

2
tests/check/elements/d3d11colorconvert.c
View file

@ -56,7 +56,7 @@ static const gchar *RGB_FORMATS[] = {
};
static const gchar *PACKED_YUV_FORMATS[] = {
"YUY2", "UYVY", "VYUY", "Y210", "Y410",
"Y410",
};
static const gchar *GRAY_FORMATS[] = {