mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 17:50:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

multiqueue: Handle use-interleave latency live pipelines

Browse source 
Due to the dynamic nature of multiqueue, when `use-interleave` is used we can't
report a maximum tolerated latency (when queried) since it is calculated
dynamically.

When in such live pipelines, we need to make sure multiqueue can handle the
lowest global latency (provided by this event). Failure to do that would
result in not providing enough buffering for a realtime pipeline.

Fixes #1732

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3792>
This commit is contained in:
Edward Hervey 2023-01-23 17:26:07 +01:00 committed by GStreamer Marge Bot
parent a70935782e
commit 54697df6e3
1 changed files with 28 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
subprojects/gstreamer/plugins/elements/gstmultiqueue.c
View file

@ -2872,6 +2872,34 @@ gst_multi_queue_src_event (GstPad * pad, GstObject * parent, GstEvent * event)
}
switch (GST_EVENT_TYPE (event)) {
case GST_EVENT_LATENCY:
{
GstClockTime latency = GST_CLOCK_TIME_NONE;
gst_event_parse_latency (event, &latency);
if (GST_CLOCK_TIME_IS_VALID (latency)) {
GST_MULTI_QUEUE_MUTEX_LOCK (mq);
if (latency > mq->min_interleave_time) {
/* Due to the dynamic nature of multiqueue, whe `use-interleave` is
* used we can't report a maximum tolerated latency (when queried)
* since it is calculated dynamically.
*
* When in such live pipelines, we need to make sure multiqueue can
* handle the lowest global latency (provided by this event). Failure
* to do that would result in not providing enough buffering for a
* realtime pipeline.
*/
GST_DEBUG_OBJECT (mq,
"Raising minimum interleave time to %" GST_TIME_FORMAT,
GST_TIME_ARGS (latency));
mq->min_interleave_time = latency;
if (mq->use_interleave)
calculate_interleave (mq, NULL);
}
GST_MULTI_QUEUE_MUTEX_UNLOCK (mq);
}
ret = gst_pad_push_event (sinkpad, event);
}
break;
case GST_EVENT_RECONFIGURE:
GST_MULTI_QUEUE_MUTEX_LOCK (mq);
if (sq->srcresult == GST_FLOW_NOT_LINKED) {