mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-30 12:49:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

glcolorconvertelement: Also unref caps in ::stop() already

Browse source 
They are not useful anymore afterwards, so keeping them until ::finalize()
might only cause someone to use them later and then fail.
This commit is contained in:
Sebastian Dröge 2015-04-17 14:03:21 +02:00
parent 17446a420c
commit 53ed701974
1 changed files with 3 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ext/gl/gstglcolorconvertelement.c
View file

@ -35,7 +35,6 @@ G_DEFINE_TYPE_WITH_CODE (GstGLColorConvertElement, gst_gl_color_convert_element,
"glconvertelement", 0, "convert"); "glconvertelement", 0, "convert");
); );
static void gst_gl_color_convert_element_finalize (GObject * object);
static gboolean gst_gl_color_convert_element_set_caps (GstBaseTransform * bt, static gboolean gst_gl_color_convert_element_set_caps (GstBaseTransform * bt,
GstCaps * in_caps, GstCaps * out_caps); GstCaps * in_caps, GstCaps * out_caps);
static GstCaps *gst_gl_color_convert_element_transform_caps (GstBaseTransform * static GstCaps *gst_gl_color_convert_element_transform_caps (GstBaseTransform *
@ -72,6 +71,9 @@ gst_gl_color_convert_element_stop (GstBaseTransform * bt)
convert->convert = NULL; convert->convert = NULL;
} }
gst_caps_replace (&convert->in_caps, NULL);
gst_caps_replace (&convert->out_caps, NULL);
return return
GST_BASE_TRANSFORM_CLASS (gst_gl_color_convert_element_parent_class)->stop GST_BASE_TRANSFORM_CLASS (gst_gl_color_convert_element_parent_class)->stop
(bt); (bt);
@ -105,8 +107,6 @@ gst_gl_color_convert_element_class_init (GstGLColorConvertElementClass * klass)
"OpenGL color converter", "Filter/Converter/Video", "OpenGL color converter", "Filter/Converter/Video",
"Converts between color spaces using OpenGL shaders", "Converts between color spaces using OpenGL shaders",
"Matthew Waters <matthew@centricular.com>"); "Matthew Waters <matthew@centricular.com>");
G_OBJECT_CLASS (klass)->finalize = gst_gl_color_convert_element_finalize;
} }
static void static void
@ -116,17 +116,6 @@ gst_gl_color_convert_element_init (GstGLColorConvertElement * convert)
TRUE); TRUE);
} }
static void
gst_gl_color_convert_element_finalize (GObject * object)
{
GstGLColorConvertElement *convert = GST_GL_COLOR_CONVERT_ELEMENT (object);
gst_caps_replace (&convert->in_caps, NULL);
gst_caps_replace (&convert->out_caps, NULL);
G_OBJECT_CLASS (gst_gl_color_convert_element_parent_class)->finalize (object);
}
static gboolean static gboolean
gst_gl_color_convert_element_set_caps (GstBaseTransform * bt, gst_gl_color_convert_element_set_caps (GstBaseTransform * bt,
GstCaps * in_caps, GstCaps * out_caps) GstCaps * in_caps, GstCaps * out_caps)