mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-05 06:58:56 +00:00
Code Issues 1 Projects Releases Wiki Activity

element: Fix doc and default implementation of send_event

Browse source 
The documentation states that gst_element_send_event is to "send an event
to an element".

Therefore we *send* upstream events to a source pad and downstream events
to a sink pad
This commit is contained in:
Edward Hervey 2014-11-28 16:25:02 +01:00
parent 78577fd8e4
commit 53cbbcd8d9
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst/gstelement.c
View file

@ -1516,7 +1516,7 @@ gst_element_default_send_event (GstElement * element, GstEvent * event)
(GST_PAD_DIRECTION (pad) == GST_PAD_SRC ? "src" : "sink"), (GST_PAD_DIRECTION (pad) == GST_PAD_SRC ? "src" : "sink"),
GST_DEBUG_PAD_NAME (pad)); GST_DEBUG_PAD_NAME (pad));
result = gst_pad_push_event (pad, event); result = gst_pad_send_event (pad, event);
gst_object_unref (pad); gst_object_unref (pad);
} else { } else {
GST_CAT_INFO (GST_CAT_ELEMENT_PADS, "can't send %s event on element %s", GST_CAT_INFO (GST_CAT_ELEMENT_PADS, "can't send %s event on element %s",
@ -1533,7 +1533,7 @@ gst_element_default_send_event (GstElement * element, GstEvent * event)
* *
* Sends an event to an element. If the element doesn't implement an * Sends an event to an element. If the element doesn't implement an
* event handler, the event will be pushed on a random linked sink pad for * event handler, the event will be pushed on a random linked sink pad for
* upstream events or a random linked source pad for downstream events. * downstream events or a random linked source pad for upstream events.
* *
* This function takes ownership of the provided event so you should * This function takes ownership of the provided event so you should
* gst_event_ref() it if you want to reuse the event after this call. * gst_event_ref() it if you want to reuse the event after this call.