scripts: improve git-update.sh status message

By default when the script is about to exit (normally or due to an error),
it checks whether $ERROR_LOG file exists.  If the log file exists, the
script prints a "Failures: " message prefix and dumps the log file to the
output.

Apparently the log file is always created and if the update/build is
successful, the script finishes with a bit misleading "Failures: " message.

An improvement provided with this change lets the log file to be created as
needed, i.e. if there's an error message to be printed.  If the file
doesn't exists, the script prints a "Update done" message which clearly
indicates success.

https://bugzilla.gnome.org/show_bug.cgi?id=701177
This commit is contained in:
Krzysztof Konopko 2013-05-28 23:34:54 +01:00 committed by Tim-Philipp Müller
parent 10099e1e70
commit 527423fcd9

View file

@ -28,7 +28,6 @@ tmp=$tmp/git-update.$(date +%Y%m%d-%H%M-).$RANDOM.$RANDOM.$RANDOM.$$
} }
ERROR_LOG="$tmp/failures.log" ERROR_LOG="$tmp/failures.log"
touch $ERROR_LOG
ERROR_RETURN=255 ERROR_RETURN=255
for m in $CORE $MODULES $EXTRA_MODULES; do for m in $CORE $MODULES $EXTRA_MODULES; do
@ -124,6 +123,7 @@ if test -e $ERROR_LOG; then
echo echo
cat $ERROR_LOG cat $ERROR_LOG
else else
echo "Update done"
rm -rf "$tmp" rm -rf "$tmp"
fi fi
exit exit