mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst-libs/gst/tag/gsttagdemux.c: Post an error message if we can't pull as many bytes as we need for the tag. This mak...

Browse source 
Original commit message from CVS:
* gst-libs/gst/tag/gsttagdemux.c: (gst_tag_demux_pull_start_tag):
Post an error message if we can't pull as many bytes as we need
for the tag. This makes sure the user gets to see a proper error
message if a file with a partial ID3 tag is fed to decodebin, and
not a 'no ID3 tag demuxer' error, which would be confusing
(see #508138).
This commit is contained in:
Tim-Philipp Müller 2008-01-08 21:10:02 +00:00
parent 939d39cdf4
commit 526fd3d7da
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,12 @@
2008-01-08 Tim-Philipp Müller <tim at centricular dot net>
* gst-libs/gst/tag/gsttagdemux.c: (gst_tag_demux_pull_start_tag):
Post an error message if we can't pull as many bytes as we need
for the tag. This makes sure the user gets to see a proper error
message if a file with a partial ID3 tag is fed to decodebin, and
not a 'no ID3 tag demuxer' error, which would be confusing
(see #508138).
2008-01-08 Tim-Philipp Müller <tim at centricular dot net> 2008-01-08 Tim-Philipp Müller <tim at centricular dot net>
* gst-libs/gst/pbutils/descriptions.c: (formats): * gst-libs/gst/pbutils/descriptions.c: (formats):

2
gst-libs/gst/tag/gsttagdemux.c
View file

@ -1035,6 +1035,8 @@ gst_tag_demux_pull_start_tag (GstTagDemux * demux, GstTagList ** tags)
if (GST_BUFFER_SIZE (buffer) < tagsize) { if (GST_BUFFER_SIZE (buffer) < tagsize) {
GST_DEBUG_OBJECT (demux, "Only managed to read %u bytes from file", GST_DEBUG_OBJECT (demux, "Only managed to read %u bytes from file",
GST_BUFFER_SIZE (buffer)); GST_BUFFER_SIZE (buffer));
GST_ELEMENT_ERROR (demux, STREAM, DECODE,
(_("Failed to read tag: not enough data")), (NULL));
goto done; goto done;
} }
} }