mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-12-24 17:20:36 +00:00
validate: fix issues with a couple of string constants
Fix missing and/or dupplicated separators, bogus breaks, typos, etc.
This commit is contained in:
parent
9ea012de22
commit
51a921b34b
7 changed files with 22 additions and 22 deletions
|
@ -823,7 +823,7 @@ gst_validate_pad_monitor_check_late_serialized_events (GstValidatePadMonitor *
|
||||||
gchar *event_str = _get_event_string (data->event);
|
gchar *event_str = _get_event_string (data->event);
|
||||||
|
|
||||||
GST_VALIDATE_REPORT (monitor, SERIALIZED_EVENT_WASNT_PUSHED_IN_TIME,
|
GST_VALIDATE_REPORT (monitor, SERIALIZED_EVENT_WASNT_PUSHED_IN_TIME,
|
||||||
"Serialized event %s wasn't pushed before expected " "timestamp %"
|
"Serialized event %s wasn't pushed before expected timestamp %"
|
||||||
GST_TIME_FORMAT " on pad %s:%s", event_str,
|
GST_TIME_FORMAT " on pad %s:%s", event_str,
|
||||||
GST_TIME_ARGS (data->timestamp),
|
GST_TIME_ARGS (data->timestamp),
|
||||||
GST_DEBUG_PAD_NAME (GST_VALIDATE_PAD_MONITOR_GET_PAD (monitor)));
|
GST_DEBUG_PAD_NAME (GST_VALIDATE_PAD_MONITOR_GET_PAD (monitor)));
|
||||||
|
@ -1555,7 +1555,7 @@ gst_validate_pad_monitor_common_event_check (GstValidatePadMonitor *
|
||||||
|
|
||||||
if (pad_monitor->pending_flush_stop) {
|
if (pad_monitor->pending_flush_stop) {
|
||||||
GST_VALIDATE_REPORT (pad_monitor, EVENT_FLUSH_START_UNEXPECTED,
|
GST_VALIDATE_REPORT (pad_monitor, EVENT_FLUSH_START_UNEXPECTED,
|
||||||
"Received flush-start from " " when flush-stop was expected");
|
"Received flush-start from when flush-stop was expected");
|
||||||
}
|
}
|
||||||
pad_monitor->pending_flush_stop = TRUE;
|
pad_monitor->pending_flush_stop = TRUE;
|
||||||
}
|
}
|
||||||
|
@ -1648,7 +1648,7 @@ _should_check_buffers (GstValidatePadMonitor * pad_monitor,
|
||||||
if (!gst_validate_media_descriptor_detects_frames
|
if (!gst_validate_media_descriptor_detects_frames
|
||||||
(monitor->media_descriptor)) {
|
(monitor->media_descriptor)) {
|
||||||
GST_DEBUG_OBJECT (pad,
|
GST_DEBUG_OBJECT (pad,
|
||||||
"No frame detection media descriptor " "=> not buffer checking");
|
"No frame detection media descriptor => not buffer checking");
|
||||||
pad_monitor->check_buffers = FALSE;
|
pad_monitor->check_buffers = FALSE;
|
||||||
} else if (pad_monitor->all_bufs == NULL &&
|
} else if (pad_monitor->all_bufs == NULL &&
|
||||||
!gst_validate_media_descriptor_get_buffers (monitor->media_descriptor,
|
!gst_validate_media_descriptor_get_buffers (monitor->media_descriptor,
|
||||||
|
@ -2359,7 +2359,7 @@ gst_validate_pad_monitor_buffer_probe (GstPad * pad, GstBuffer * buffer,
|
||||||
/* TODO is this a timestamp issue? */
|
/* TODO is this a timestamp issue? */
|
||||||
GST_VALIDATE_REPORT (monitor, BUFFER_IS_OUT_OF_SEGMENT,
|
GST_VALIDATE_REPORT (monitor, BUFFER_IS_OUT_OF_SEGMENT,
|
||||||
"buffer is out of segment and shouldn't be pushed. Timestamp: %"
|
"buffer is out of segment and shouldn't be pushed. Timestamp: %"
|
||||||
GST_TIME_FORMAT " - duration: %" GST_TIME_FORMAT ". Range: %"
|
GST_TIME_FORMAT " - Duration: %" GST_TIME_FORMAT ". Range: %"
|
||||||
GST_TIME_FORMAT " - %" GST_TIME_FORMAT,
|
GST_TIME_FORMAT " - %" GST_TIME_FORMAT,
|
||||||
GST_TIME_ARGS (GST_BUFFER_TIMESTAMP (buffer)),
|
GST_TIME_ARGS (GST_BUFFER_TIMESTAMP (buffer)),
|
||||||
GST_TIME_ARGS (GST_BUFFER_DURATION (buffer)),
|
GST_TIME_ARGS (GST_BUFFER_DURATION (buffer)),
|
||||||
|
|
|
@ -307,7 +307,7 @@ _append_query_caps_failure_details (GstValidatePadMonitor * monitor,
|
||||||
|
|
||||||
g_string_append_printf (str,
|
g_string_append_printf (str,
|
||||||
"\n - The QUERY filter caps is EMPTY, this is invalid and is a bug in "
|
"\n - The QUERY filter caps is EMPTY, this is invalid and is a bug in "
|
||||||
" a previous element (probably in: '%s')\n",
|
"a previous element (probably in: '%s')\n",
|
||||||
prev_path ? prev_path : "no suspect");
|
prev_path ? prev_path : "no suspect");
|
||||||
g_free (prev_path);
|
g_free (prev_path);
|
||||||
}
|
}
|
||||||
|
@ -437,8 +437,8 @@ _generate_not_negotiated_error_report (GstMessage * msg)
|
||||||
else if (last_refused_caps_monitor)
|
else if (last_refused_caps_monitor)
|
||||||
_append_accept_caps_failure_details (last_refused_caps_monitor, str);
|
_append_accept_caps_failure_details (last_refused_caps_monitor, str);
|
||||||
else {
|
else {
|
||||||
GST_ERROR ("We should always be able to generate detailed report"
|
GST_ERROR ("We should always be able to generate a detailed report"
|
||||||
" about why negotiation failed, please report a bug against"
|
" about why negotiation failed. Please report a bug against"
|
||||||
" gst-devtools:validate with this message and a way to reproduce.");
|
" gst-devtools:validate with this message and a way to reproduce.");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -214,7 +214,7 @@ gst_validate_report_load_issues (void)
|
||||||
REGISTER_VALIDATE_ISSUE (ISSUE, BUFFER_IS_OUT_OF_SEGMENT,
|
REGISTER_VALIDATE_ISSUE (ISSUE, BUFFER_IS_OUT_OF_SEGMENT,
|
||||||
_("buffer is out of the segment range"),
|
_("buffer is out of the segment range"),
|
||||||
_("buffer being pushed is out of the current segment's start-stop "
|
_("buffer being pushed is out of the current segment's start-stop "
|
||||||
" range. Meaning it is going to be discarded downstream without "
|
"range. Meaning it is going to be discarded downstream without "
|
||||||
"any use"));
|
"any use"));
|
||||||
REGISTER_VALIDATE_ISSUE (WARNING, BUFFER_TIMESTAMP_OUT_OF_RECEIVED_RANGE,
|
REGISTER_VALIDATE_ISSUE (WARNING, BUFFER_TIMESTAMP_OUT_OF_RECEIVED_RANGE,
|
||||||
_("buffer timestamp is out of the received buffer timestamps' range"),
|
_("buffer timestamp is out of the received buffer timestamps' range"),
|
||||||
|
@ -874,7 +874,7 @@ gst_validate_printf_valist (gpointer source, const gchar * format, va_list args)
|
||||||
GstValidateActionParameter playback_time_param = {
|
GstValidateActionParameter playback_time_param = {
|
||||||
.name = "playback-time",
|
.name = "playback-time",
|
||||||
.description =
|
.description =
|
||||||
"The playback time at which the action " "will be executed",
|
"The playback time at which the action will be executed",
|
||||||
.mandatory = FALSE,
|
.mandatory = FALSE,
|
||||||
.types = "double,string",
|
.types = "double,string",
|
||||||
.possible_variables =
|
.possible_variables =
|
||||||
|
@ -920,7 +920,7 @@ gst_validate_printf_valist (gpointer source, const gchar * format, va_list args)
|
||||||
has_parameters = TRUE;
|
has_parameters = TRUE;
|
||||||
g_string_append_printf (string,
|
g_string_append_printf (string,
|
||||||
"\n optional : "
|
"\n optional : "
|
||||||
"Don't raise an error if this action hasn't been executed of failed"
|
"Don't raise an error if this action hasn't been executed or failed"
|
||||||
"\n%-32s Possible types:"
|
"\n%-32s Possible types:"
|
||||||
"\n%-32s boolean"
|
"\n%-32s boolean"
|
||||||
"\n%-32s Default: false","","","");
|
"\n%-32s Default: false","","","");
|
||||||
|
|
|
@ -1448,7 +1448,7 @@ _should_execute_action (GstValidateScenario * scenario, GstValidateAction * act,
|
||||||
GST_VALIDATE_REPORT (scenario, SCENARIO_ACTION_EXECUTION_ERROR,
|
GST_VALIDATE_REPORT (scenario, SCENARIO_ACTION_EXECUTION_ERROR,
|
||||||
"Trying to execute action %s with playback time %" GST_TIME_FORMAT
|
"Trying to execute action %s with playback time %" GST_TIME_FORMAT
|
||||||
" after the pipeline has been destroyed. It is impossible"
|
" after the pipeline has been destroyed. It is impossible"
|
||||||
" to execute an action with a playback time specified "
|
" to execute an action with a playback time specified"
|
||||||
" after the pipeline has been destroyed",
|
" after the pipeline has been destroyed",
|
||||||
act->type, GST_TIME_ARGS (act->playback_time));
|
act->type, GST_TIME_ARGS (act->playback_time));
|
||||||
|
|
||||||
|
@ -1984,7 +1984,7 @@ _execute_wait_for_signal (GstValidateScenario * scenario,
|
||||||
if (scenario->pipeline == NULL) {
|
if (scenario->pipeline == NULL) {
|
||||||
GST_VALIDATE_REPORT (scenario, SCENARIO_ACTION_EXECUTION_ERROR,
|
GST_VALIDATE_REPORT (scenario, SCENARIO_ACTION_EXECUTION_ERROR,
|
||||||
"Can't execute a 'wait for signal' action after the pipeline "
|
"Can't execute a 'wait for signal' action after the pipeline "
|
||||||
" has been destroyed.");
|
"has been destroyed.");
|
||||||
|
|
||||||
return GST_VALIDATE_EXECUTE_ACTION_ERROR_REPORTED;
|
return GST_VALIDATE_EXECUTE_ACTION_ERROR_REPORTED;
|
||||||
}
|
}
|
||||||
|
@ -2021,7 +2021,7 @@ _execute_wait_for_message (GstValidateScenario * scenario,
|
||||||
if (scenario->pipeline == NULL) {
|
if (scenario->pipeline == NULL) {
|
||||||
GST_VALIDATE_REPORT (scenario, SCENARIO_ACTION_EXECUTION_ERROR,
|
GST_VALIDATE_REPORT (scenario, SCENARIO_ACTION_EXECUTION_ERROR,
|
||||||
"Can't execute a 'wait for message' action after the pipeline "
|
"Can't execute a 'wait for message' action after the pipeline "
|
||||||
" has been destroyed.");
|
"has been destroyed.");
|
||||||
|
|
||||||
return GST_VALIDATE_EXECUTE_ACTION_ERROR_REPORTED;
|
return GST_VALIDATE_EXECUTE_ACTION_ERROR_REPORTED;
|
||||||
}
|
}
|
||||||
|
@ -2746,8 +2746,8 @@ gst_validate_scenario_load (GstValidateScenario * scenario,
|
||||||
/* First check if the scenario name is not a full path to the
|
/* First check if the scenario name is not a full path to the
|
||||||
* actual scenario */
|
* actual scenario */
|
||||||
if (g_file_test (scenarios[i], G_FILE_TEST_IS_REGULAR)) {
|
if (g_file_test (scenarios[i], G_FILE_TEST_IS_REGULAR)) {
|
||||||
GST_DEBUG_OBJECT (scenario, "Scenario: %s is a full path to a scenario "
|
GST_DEBUG_OBJECT (scenario, "Scenario: %s is a full path to a scenario. "
|
||||||
"trying to load it", scenarios[i]);
|
"Trying to load it", scenarios[i]);
|
||||||
if ((ret = _load_scenario_file (scenario, scenarios[i], &is_config)))
|
if ((ret = _load_scenario_file (scenario, scenarios[i], &is_config)))
|
||||||
goto check_scenario;
|
goto check_scenario;
|
||||||
}
|
}
|
||||||
|
@ -2905,8 +2905,8 @@ gst_validate_scenario_class_init (GstValidateScenarioClass * klass)
|
||||||
|
|
||||||
g_object_class_install_property (object_class, PROP_HANDLES_STATE,
|
g_object_class_install_property (object_class, PROP_HANDLES_STATE,
|
||||||
g_param_spec_boolean ("handles-states", "Handles state",
|
g_param_spec_boolean ("handles-states", "Handles state",
|
||||||
"True if the application should not set handle the first state change "
|
"True if the application should not handle the first state change. "
|
||||||
" False if it is application responsibility",
|
"False if it is application responsibility",
|
||||||
FALSE, G_PARAM_READABLE));
|
FALSE, G_PARAM_READABLE));
|
||||||
|
|
||||||
g_object_class_install_property (object_class,
|
g_object_class_install_property (object_class,
|
||||||
|
@ -3875,7 +3875,7 @@ init_scenarios (void)
|
||||||
|
|
||||||
REGISTER_ACTION_TYPE ("stop", _execute_stop, NULL,
|
REGISTER_ACTION_TYPE ("stop", _execute_stop, NULL,
|
||||||
"Stops the execution of the scenario. It will post a 'request-state'"
|
"Stops the execution of the scenario. It will post a 'request-state'"
|
||||||
" message on the bus with NULL as a requested state "
|
" message on the bus with NULL as a requested state"
|
||||||
" and the application is responsible for stopping itself."
|
" and the application is responsible for stopping itself."
|
||||||
" if you override that action type, make sure to link up.",
|
" if you override that action type, make sure to link up.",
|
||||||
GST_VALIDATE_ACTION_TYPE_NO_EXECUTION_NOT_FATAL);
|
GST_VALIDATE_ACTION_TYPE_NO_EXECUTION_NOT_FATAL);
|
||||||
|
|
|
@ -518,13 +518,13 @@ gboolean
|
||||||
tmptag->data)->taglist != NULL) {
|
tmptag->data)->taglist != NULL) {
|
||||||
GST_DEBUG ("Tag not found %s", tag);
|
GST_DEBUG ("Tag not found %s", tag);
|
||||||
} else {
|
} else {
|
||||||
GST_DEBUG ("Tag not not properly deserialized");
|
GST_DEBUG ("Tag not properly deserialized");
|
||||||
}
|
}
|
||||||
|
|
||||||
ret = FALSE;
|
ret = FALSE;
|
||||||
}
|
}
|
||||||
|
|
||||||
GST_DEBUG ("Tag properly found found %s", tag);
|
GST_DEBUG ("Tag properly found %s", tag);
|
||||||
g_free (tag);
|
g_free (tag);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -882,7 +882,7 @@ gst_validate_media_descriptor_writer_add_frame (GstValidateMediaDescriptorWriter
|
||||||
g_markup_printf_escaped (" <frame duration=\"%" G_GUINT64_FORMAT
|
g_markup_printf_escaped (" <frame duration=\"%" G_GUINT64_FORMAT
|
||||||
"\" id=\"%i\" is-keyframe=\"%s\" offset=\"%" G_GUINT64_FORMAT
|
"\" id=\"%i\" is-keyframe=\"%s\" offset=\"%" G_GUINT64_FORMAT
|
||||||
"\" offset-end=\"%" G_GUINT64_FORMAT "\" pts=\"%" G_GUINT64_FORMAT
|
"\" offset-end=\"%" G_GUINT64_FORMAT "\" pts=\"%" G_GUINT64_FORMAT
|
||||||
"\" dts=\"%" G_GUINT64_FORMAT "\" running-time=\"%" G_GUINT64_FORMAT
|
"\" dts=\"%" G_GUINT64_FORMAT "\" running-time=\"%" G_GUINT64_FORMAT
|
||||||
"\" checksum=\"%s\"/>",
|
"\" checksum=\"%s\"/>",
|
||||||
fnode->duration, id, fnode->is_keyframe ? "true" : "false",
|
fnode->duration, id, fnode->is_keyframe ? "true" : "false",
|
||||||
fnode->offset, fnode->offset_end, fnode->pts, fnode->dts,
|
fnode->offset, fnode->offset_end, fnode->pts, fnode->dts,
|
||||||
|
|
|
@ -206,7 +206,7 @@ gst_validate_media_descriptor_class_init (GstValidateMediaDescriptorClass *
|
||||||
|
|
||||||
g_object_class_install_property (object_class, PROP_RUNNER,
|
g_object_class_install_property (object_class, PROP_RUNNER,
|
||||||
g_param_spec_object ("validate-runner", "VALIDATE Runner",
|
g_param_spec_object ("validate-runner", "VALIDATE Runner",
|
||||||
"The Validate runner to " "report errors to",
|
"The Validate runner to report errors to",
|
||||||
GST_TYPE_VALIDATE_RUNNER,
|
GST_TYPE_VALIDATE_RUNNER,
|
||||||
G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE));
|
G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE));
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue