mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

adaptivedemux: Workaround for live seek ranges when advancing

Browse source 
This is a workaround for a regression introduced by
f4190a49c0
 ( adaptivedemux: Check live seeking range more often )

The goal of the previous commit was to be able to cope with non-1.0
rates on live streams which have a "seeking window" (i.e. the server
keeps around quite a bit of the live stream so you can seek back into
it).

Without that commit, two different kind of issues would happen:
* When doing reverse playback, you would never check whether you
  are outside of the seekable region. And would then continuously
  try to download fragments that are no longer present.
* When doing fast forward, you would end up requesting fragments
  which are not present yet.

In order to determine whether one was *really* outside of the seekable
window, we check whether the current stream position is still
within the seekable region.

The *problem* though with that commit is that it assumes that subclasses
will return continuously updated seeking ranges (i.e. dependent on the
current time), which is *NOT* the case.

For example:
* dashdemux does use the current UTC to determine the seekable region
* hlsdemux uses the values from the last updated manifest

Therefore if one downloads fragments faster than realtime, for HLS
we would end up at the end of the last manifest seekable range, and
the previous commit would consider the stream as being ended... which
is not the case.

In the long run, we need to figure out a way to cope with non-1.0
rates on live streams for all types of stream (including HLS).

https://bugzilla.gnome.org/show_bug.cgi?id=783075
This commit is contained in:
Edward Hervey 2017-07-13 12:57:12 +02:00 committed by Edward Hervey
parent ead63a2686
commit 50f92fab89
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst-libs/gst/adaptivedemux/gstadaptivedemux.c
View file

@ -3743,9 +3743,12 @@ gst_adaptive_demux_stream_download_loop (GstAdaptiveDemuxStream * stream)
break; /* all is good, let's go */ break; /* all is good, let's go */
case GST_FLOW_EOS: case GST_FLOW_EOS:
GST_DEBUG_OBJECT (stream->pad, "EOS, checking to stop download loop"); GST_DEBUG_OBJECT (stream->pad, "EOS, checking to stop download loop");
/* we push the EOS after releasing the object lock */ /* we push the EOS after releasing the object lock */
if (gst_adaptive_demux_is_live (demux) if (gst_adaptive_demux_is_live (demux)
&& gst_adaptive_demux_stream_in_live_seek_range (demux, stream)) { && (demux->segment.rate == 1.0
|| gst_adaptive_demux_stream_in_live_seek_range (demux,
stream))) {
GstAdaptiveDemuxClass *demux_class = GstAdaptiveDemuxClass *demux_class =
GST_ADAPTIVE_DEMUX_GET_CLASS (demux); GST_ADAPTIVE_DEMUX_GET_CLASS (demux);