mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-13 12:51:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst-validate: Don't treat FALSE when sending flushes as an error

Browse source 
gst_element_send_event(FLUSH_START / FLUSH_STOP) returns FALSE in cases
where any of the most downstream elements have unlinked pads, even if
the pipeline is successfully flushed.

Currently this is considered expected behavior in GStreamer. This patch
updates gst-validate to treat it as such and therefore not fail the test
for a "failing" flush.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7064>
This commit is contained in:
Alicia Boya García 2024-06-19 15:31:11 +02:00 committed by GStreamer Marge Bot
parent 0f7bb97e81
commit 506af5b8e4
1 changed files with 20 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
subprojects/gst-devtools/validate/gst/validate/gst-validate-scenario.c
View file

@ -4432,6 +4432,7 @@ _execute_flush (GstValidateScenario * scenario, GstValidateAction * action)
{
GstElement *target;
GstEvent *event;
gboolean ret;
gboolean reset_time = TRUE;
target = _get_target_element (scenario, action);
@ -4446,19 +4447,28 @@ _execute_flush (GstValidateScenario * scenario, GstValidateAction * action)
gst_structure_get_boolean (action->structure, "reset-time", &reset_time);
// FLUSH_START and FLUSH_STOP are "fire-and-forget" events.
//
// In the case of a pipeline where the most downstream element has unlinked srcpads
// (as is the case for many autoplugging elements before preroll), the event will
// "fail" due to "not-linked" but will have still correctly flushed all the existing
// elements and pads.
//
// For this reason, we cannot consider a test failed if a FLUSH_START or FLUSH_STOP
// "fails". However, since those "failures" reflect edge cases, we still want to log
// them as they can become useful during debugging.
//
// Source: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7064#note_2460206
event = gst_event_new_flush_start ();
if (!gst_element_send_event (target, event)) {
GST_VALIDATE_REPORT_ACTION (scenario, action,
SCENARIO_ACTION_EXECUTION_ERROR, "FLUSH_START event was not handled");
return GST_VALIDATE_EXECUTE_ACTION_ERROR_REPORTED;
}
ret = gst_element_send_event (target, event);
GST_DEBUG_OBJECT (scenario, "Sending FLUSH_START event returned %s.",
ret ? "TRUE" : "FALSE");
event = gst_event_new_flush_stop (reset_time);
if (!gst_element_send_event (target, event)) {
GST_VALIDATE_REPORT_ACTION (scenario, action,
SCENARIO_ACTION_EXECUTION_ERROR, "FLUSH_STOP event was not handled");
return GST_VALIDATE_EXECUTE_ACTION_ERROR_REPORTED;
}
ret = gst_element_send_event (target, event);
GST_DEBUG_OBJECT (scenario, "Sending FLUSH_STOP event returned %s.",
ret ? "TRUE" : "FALSE");
return GST_VALIDATE_EXECUTE_ACTION_OK;
}