mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 19:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

qmlgl: don't critical on input events before input format has been set

Browse source 
Accessing the unset GstVideoInfo would result in criticals

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1065>
This commit is contained in:
Matthew Waters 2021-08-27 13:30:57 +10:00
parent 5472252688
commit 50661c1aa9
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ext/qt/qtitem.cc
View file

@ -353,6 +353,7 @@ QtGLVideoItem::mapPointToStreamSize(QPointF pos)
stream_y = CLAMP(stream_y, 0., stream_height);
GST_TRACE ("transform %fx%f into %fx%f", x, y, stream_x, stream_y);
return QPointF(stream_x, stream_y);
}
@ -397,6 +398,13 @@ QtGLVideoItem::hoverMoveEvent(QHoverEvent * event)
quint32 button = !!mousePressedButton;
g_mutex_lock (&this->priv->lock);
/* can't do anything when we don't have input format */
if (!this->priv->negotiated) {
g_mutex_unlock (&this->priv->lock);
return;
}
if (event->pos() != event->oldPos()) {
QPointF pos = mapPointToStreamSize(event->pos());
GstElement *element = GST_ELEMENT_CAST (g_weak_ref_get (&this->priv->sink));
@ -430,6 +438,12 @@ QtGLVideoItem::sendMouseEvent(QMouseEvent * event, const gchar * type)
g_mutex_lock (&this->priv->lock);
/* can't do anything when we don't have input format */
if (!this->priv->negotiated) {
g_mutex_unlock (&this->priv->lock);
return;
}
QPointF pos = mapPointToStreamSize(event->pos());
gchar* event_type = g_strconcat ("mouse-button-", type, NULL);
GstElement *element = GST_ELEMENT_CAST (g_weak_ref_get (&this->priv->sink));