validate: Rework the action parameter API

Making it possible to properly define parameters, and describe them.

+ Document all action types!

validate/gst/validate/gst-validate-internal.h

@@ -29,6 +29,7 @@ GST_DEBUG_CATEGORY_EXTERN (gstvalidate_debug);
 
 typedef struct _GstValidateScenario        GstValidateScenario;
 typedef struct _GstValidateAction          GstValidateAction;
+typedef struct _GstValidateActionParameter GstValidateActionParameter;
 typedef gboolean (*GstValidateExecuteAction) (GstValidateScenario * scenario, GstValidateAction * action);
 
 struct _GstValidateActionType
@@ -39,8 +40,7 @@ struct _GstValidateActionType
 
   GstValidateExecuteAction execute;
 
-  gchar **mandatory_fields;
+  GstValidateActionParameter *parameters;
-  gchar **option_fields;
 
   gchar *description;
   gboolean is_config;

validate/gst/validate/gst-validate-report.c

@@ -487,24 +487,86 @@ gst_validate_printf_valist (gpointer source, const gchar * format, va_list args)
             "\n%s    Is config action (meaning it will be executing right "
             "at the begining of the execution of the pipeline)", type->name);
 
-      tmp = g_strdup_printf ("\n%s        ", type->name);
+      tmp = g_strdup_printf ("\n%s      ", type->name);
       desc =
           g_regex_replace (newline_regex, type->description, -1, 0, tmp, 0,
           NULL);
-      g_string_append_printf (string, "\n%s    Description: \n%s        %s",
+      g_string_append_printf (string, "\n%s\n%s    Description: \n%s      %s",
-          type->name, type->name, desc);
+          type->name, type->name, type->name, desc);
       g_free (desc);
       g_free (tmp);
 
+      if (type->parameters) {
+        g_string_append_printf (string, "\n%s\n%s    Parametters:",
+            type->name, type->name);
 
-      if (type->mandatory_fields) {
+        for (i = 0; type->parameters[i].name; i++) {
-        g_string_append_printf (string, "\n%s    Mandatory fileds:",
+          gint nw = 0;
-            type->name);
+          gchar *param_head =
-        for (i = 0; type->mandatory_fields[i]; i++)
+              g_strdup_printf ("      %s", type->parameters[i].name);
-          g_string_append_printf (string,
+          gchar *tmp_head = g_strdup_printf ("\n%s %-30s : %s", type->name,
-              "\n%s        %s", type->name, type->mandatory_fields[i]);
+              param_head, "something");
+
+
+          while (tmp_head[nw] != ':')
+            nw++;
+
+          g_free (tmp_head);
+
+          tmp =
+              g_strdup_printf ("\n%s%*s", type->name,
+              nw - (gint) strlen (type->name) + 1, " ");
+
+          if (g_strcmp0 (type->parameters[i].description, "")) {
+            desc =
+                g_regex_replace (newline_regex, type->parameters[i].description,
+                -1, 0, tmp, 0, NULL);
+          } else {
+            desc = g_strdup_printf ("No description");
+          }
+
+          g_string_append_printf (string, "\n%s %-30s : %s", type->name,
+              param_head, desc);
+          g_free (desc);
+
+          if (type->parameters[i].possible_variables) {
+            gchar *tmp1 = g_strdup_printf ("\n%s%*s", type->name,
+                nw - (gint) strlen (type->name) + 4, " ");
+            desc =
+                g_regex_replace (newline_regex,
+                type->parameters[i].possible_variables, -1, 0, tmp1, 0, NULL);
+            g_string_append_printf (string, "%sPossible variables:%s%s", tmp,
+                tmp1, desc);
+
+            g_free (tmp1);
+          }
+
+          if (type->parameters[i].types) {
+            gchar *tmp1 = g_strdup_printf ("\n%s%*s", type->name,
+                nw - (gint) strlen (type->name) + 4, " ");
+            desc =
+                g_regex_replace (newline_regex,
+                type->parameters[i].types, -1, 0, tmp1, 0, NULL);
+            g_string_append_printf (string, "%sPossible types:%s%s", tmp,
+                tmp1, desc);
+
+            g_free (tmp1);
+          }
+
+          if (!type->parameters[i].mandatory) {
+            g_string_append_printf (string, "%sDefault: %s", tmp,
+                type->parameters[i].def);
+          }
+
+          g_string_append_printf (string, "%s%s", tmp,
+              type->parameters[i].mandatory ? "Mandatory." : "Optional.");
+
+          g_free (tmp);
+          g_free (param_head);
+
+        }
       } else {
-        g_string_append_printf (string, "\n%s    No mandatory field",
+        g_string_append_printf (string, "\n%s\n%s    No Parameters", type->name,
             type->name);
 
       }

validate/gst/validate/gst-validate-scenario.c

@@ -185,7 +185,7 @@ static GstValidateActionType *gst_validate_action_type_new (void);
 static void
 _action_type_free (GstValidateActionType * type)
 {
-  g_strfreev (type->mandatory_fields);
+  g_free (type->parameters);
   g_free (type->description);
   g_free (type->name);
 }
@@ -1353,15 +1353,16 @@ _load_scenario_file (GstValidateScenario * scenario,
       goto failed;
     }
 
-    if (action_type->mandatory_fields) {
+    if (action_type->parameters) {
       guint i;
 
-      for (i = 0; action_type->mandatory_fields[i]; i++) {
+      for (i = 0; action_type->parameters[i].name; i++) {
-        if (gst_structure_has_field (structure,
+        if (action_type->parameters[i].mandatory &&
-                action_type->mandatory_fields[i]) == FALSE) {
+            gst_structure_has_field (structure,
+                action_type->parameters[i].name) == FALSE) {
           GST_ERROR_OBJECT (scenario,
               "Mandatory field '%s' not present in structure: %" GST_PTR_FORMAT,
-              action_type->mandatory_fields[i], structure);
+              action_type->parameters[i].name, structure);
           goto failed;
         }
       }
@@ -1834,31 +1835,48 @@ done:
   return res;
 }
 
-static void
-_free_action_type (GstValidateActionType * type)
-{
-  if (type->mandatory_fields)
-    g_strfreev (type->mandatory_fields);
-
-  g_free (type->description);
-
-  g_slice_free (GstValidateActionType, type);
-}
-
 void
 gst_validate_add_action_type (const gchar * type_name,
-    GstValidateExecuteAction function, const gchar * const *mandatory_fields,
+    GstValidateExecuteAction function,
+    GstValidateActionParameter * parameters,
     const gchar * description, gboolean is_config)
 {
   GstValidateActionType *type = gst_validate_action_type_new ();
+  gint n_params = is_config ? 0 : 2;
+
+  if (parameters) {
+    for (n_params = 0; parameters[n_params].name != NULL; n_params++);
+
+    n_params += 2;
+  }
+
+  if (n_params) {
+    type->parameters = g_new0 (GstValidateActionParameter, n_params);
+  }
+
+  if (parameters) {
+    memcpy (type->parameters, parameters,
+        sizeof (GstValidateActionParameter) * (n_params));
+  }
+
+  if (!is_config) {
+    type->parameters[n_params - 1].name = "playback_time";
+    type->parameters[n_params - 1].description =
+        "The playback time at which the action " "will be executed";
+    type->parameters[n_params - 1].mandatory = FALSE;
+    type->parameters[n_params - 1].types = "double,string";
+    type->parameters[n_params - 1].possible_variables =
+        "position: The current position in the stream\n"
+        "duration: The duration of the stream";
+    type->parameters[n_params - 1].def = "0.0";
+  }
 
   if (action_types_table == NULL)
     action_types_table = g_hash_table_new_full (g_str_hash, g_str_equal,
-        g_free, (GDestroyNotify) _free_action_type);
+        g_free, (GDestroyNotify) gst_mini_object_unref);
 
   type->execute = function;
   type->name = g_strdup (type_name);
-  type->mandatory_fields = g_strdupv ((gchar **) mandatory_fields);
   type->description = g_strdup (description);
   type->is_config = is_config;
 
@@ -1878,7 +1896,7 @@ gboolean
 gst_validate_print_action_types (gchar ** wanted_types, gint num_wanted_types)
 {
   GList *tmp;
-  gint nfound;
+  gint nfound = 0;
 
   for (tmp = gst_validate_list_action_types (); tmp; tmp = tmp->next) {
     gboolean print = FALSE;
@@ -1913,16 +1931,6 @@ gst_validate_print_action_types (gchar ** wanted_types, gint num_wanted_types)
 void
 init_scenarios (void)
 {
-  const gchar *seek_mandatory_fields[] = { "start", NULL };
-  const gchar *wait_mandatory_fields[] = { "duration", NULL };
-  const gchar *set_state_mandatory_fields[] = { "state", NULL };
-  const gchar *set_property_mandatory_fields[] =
-      { "target-element-name", "property-name", "property-value", NULL };
-  const gchar *set_debug_threshold_mandatory_fields[] =
-      { "debug-threshold", NULL };
-  const gchar *emit_signal_mandatory_fields[] =
-      { "target-element-name", "signal-name", NULL };
-
   GST_DEBUG_CATEGORY_INIT (gst_validate_scenario_debug, "gstvalidatescenario",
       GST_DEBUG_FG_YELLOW, "Gst validate scenarios");
 
@@ -1930,50 +1938,310 @@ init_scenarios (void)
   _gst_validate_action_type_type = gst_validate_action_type_get_type ();
 
   clean_action_str = g_regex_new ("\\\\\n|#.*\n", G_REGEX_CASELESS, 0, NULL);
-  gst_validate_add_action_type ("seek", _execute_seek, seek_mandatory_fields,
+
-      "Seeks into the files", FALSE);
+  /*  *INDENT-OFF* */
-  gst_validate_add_action_type ("pause", _execute_pause, NULL,
+  gst_validate_add_action_type ("description", _execute_seek,
+      (GstValidateActionParameter [])  {
+      {
+        .name = "summary",
+        .description = "Whether the scenario is a config only scenario (ie. explain what it does)",
+        .mandatory = FALSE,
+        .types = "sting",
+        .possible_variables = NULL,
+        .def = "'Nothing'"},
+      {
+        .name = "is-config",
+        .description = "Whether the scenario is a config only scenario",
+        .mandatory = FALSE,
+        .types = "boolean",
+        .possible_variables = NULL,
+        .def = "false"
+      },
+      {
+        .name = "handles-states",
+        .description = "Whether the scenario handles pipeline state changes from the beginning\n"
+        "in that case the application should not set the state of the pipeline to anything\n"
+        "and the scenario action will be executed from the beginning",
+        .mandatory = FALSE,
+        .types = "boolean",
+        .possible_variables = NULL,
+        .def = "false"},
+      {
+        .name = "seek",
+        .description = "Whether the scenario executes seek action or not",
+        .mandatory = FALSE,
+        .types = "boolean",
+        .possible_variables = NULL,
+        .def = "false"
+      },
+      {
+        .name = "reverse-playback",
+        .description = "Whether the scenario plays the stream backward",
+        .mandatory = FALSE,
+        .types = "boolean",
+        .possible_variables = NULL,
+        .def = "false"
+      },
+      {
+        .name = "need-clock-sync",
+        .description = "Whether the scenario needs the execution to be syncronized with the pipeline\n"
+                       "clock. Letting the user know if it can be used with a 'fakesink sync=false' sink",
+        .mandatory = FALSE,
+        .types = "boolean",
+        .possible_variables = NULL,
+        .def = "false"
+      },
+      {
+        .name = "min-media-duration",
+        .description = "Lets the user know the minimum duration of the stream for the scenario\n"
+                       "to be usable",
+        .mandatory = FALSE,
+        .types = "double",
+        .possible_variables = NULL,
+        .def = "0.0"
+      },
+      {
+        .name = "min-audio-track",
+        .description = "Lets the user know the minimum number of audio tracks the stream needs to contain\n"
+                       "for the scenario to be usable",
+        .mandatory = FALSE,
+        .types = "int",
+        .possible_variables = NULL,
+        .def = "0"
+      },
+      {
+       .name = "min-video-track",
+       .description = "Lets the user know the minimum number of video tracks the stream needs to contain\n"
+                      "for the scenario to be usable",
+       .mandatory = FALSE,
+       .types = "int",
+       .possible_variables = NULL,
+       .def = "0"
+      },
+      {
+        .name = "duration",
+        .description = "Lets the user know the time the scenario needs to be fully executed",
+        .mandatory = FALSE,
+        .types = "double, int",
+        .possible_variables = NULL,
+        .def = "infinite (GST_CLOCK_TIME_NONE)"
+      },
+      {NULL}
+      },
+      "Allows to describe the scenario in various ways",
+      TRUE);
+
+  gst_validate_add_action_type ("seek", _execute_seek,
+      (GstValidateActionParameter [])  {
+        {
+          .name = "start",
+          .description = "The starting value of the seek",
+          .mandatory = TRUE,
+          .types = "double or string",
+          .possible_variables = "position: The current position in the stream\n"
+            "duration: The duration of the stream",
+           NULL
+        },
+        {
+          .name = "rate",
+          .description = "The rate value of the seek",
+          .mandatory = FALSE,
+          .types = "double",
+          .possible_variables = NULL,
+          .def = "1.0"
+        },
+        {
+          .name = "start_type",
+          .description = "The GstSeekType to use for the start of the seek, in:\n"
+          "  [none, set, end]",
+          .mandatory = FALSE,
+          .types = "string",
+        .possible_variables = NULL,
+          .def = "set"
+        },
+        {
+          .name = "stop_type",
+          .description = "The GstSeekType to use for the stop of the seek, in:\n"
+                         "  [none, set, end]",
+          .mandatory = FALSE,
+          .types = "string",
+          .possible_variables = NULL,
+          .def = "set"
+        },
+        {"stop", "The stop value of the seek", FALSE, "double or ",
+          "position: The current position in the stream\n"
+            "duration: The duration of the stream"
+            "GST_CLOCK_TIME_NONE",
+        },
+        {NULL}
+      },
+      "Seeks into the stream, example of a seek happening when the stream reaches 5 seconds\n"
+      "or 1 eighth of its duration and seeks at 10sec or 2 eighth of its duration:\n"
+      "  seek, playback_time=\"min(5.0, (duration/8))\", start=\"min(10, 2*(duration/8))\", flags=accurate+flush",
+      FALSE
+  );
+
+  gst_validate_add_action_type ("pause", _execute_pause,
+      (GstValidateActionParameter []) {
+        {
+          .name = "duration",
+          .description = "The duration during which the stream will be paused",
+          .mandatory = FALSE,
+          .types = "double",
+          .possible_variables = NULL,
+          .def = "0.0",
+        },
+        {NULL}
+      },
       "Sets pipeline to PAUSED. You can add a 'duration'\n"
-      "parametter so the pipeline goaes back to playing after that duration\n"
+      "parametter so the pipeline goes back to playing after that duration\n"
       "(in second)", FALSE);
+
   gst_validate_add_action_type ("play", _execute_play, NULL,
       "Sets the pipeline state to PLAYING", FALSE);
+
   gst_validate_add_action_type ("stop", _execute_stop, NULL,
       "Sets the pipeline state to NULL", FALSE);
+
   gst_validate_add_action_type ("eos", _execute_eos, NULL,
       "Sends an EOS event to the pipeline", FALSE);
-  gst_validate_add_action_type ("switch-track", _execute_switch_track, NULL,
+
+  gst_validate_add_action_type ("switch-track", _execute_switch_track,
+      (GstValidateActionParameter []) {
+        {
+          .name = "type",
+          .description = "Selects which track type to change (can be 'audio', 'video',"
+                          " or 'text').",
+          .mandatory = FALSE,
+          .types = "string",
+          .possible_variables = NULL,
+          .def = "audio",
+        },
+        {
+          .name = "index",
+          .description = "Selects which track of this type to use: it can be either a number,\n"
+                         "which will be the Nth track of the given type, or a number with a '+' or\n"
+                         "'-' prefix, which means a relative change (eg, '+1' means 'next track',\n"
+                         "'-1' means 'previous track')",
+          .mandatory = FALSE,
+          .types = "string: to switch track relatively\n"
+                   "int: To use the actual index to use",
+          .possible_variables = NULL,
+          .def = "+1",
+        },
+        {NULL}
+      },
       "The 'switch-track' command can be used to switch tracks.\n"
-      "The 'type' argument selects which track type to change (can be 'audio', 'video',"
+      , FALSE);
-      " or 'text').\nThe 'index' argument selects which track of this type\n"
+
-      "to use: it can be either a number, which will be the Nth track of\n"
+  gst_validate_add_action_type ("wait", _execute_wait,
-      "the given type, or a number with a '+' or '-' prefix, which means\n"
+      (GstValidateActionParameter []) {
-      "a relative change (eg, '+1' means 'next track', '-1' means 'previous\n"
+        {
-      "track'), note that you need to state that it is a string in the scenario file\n"
+          .name = "duration",
-      "prefixing it with (string).", FALSE);
+          .description = "the duration while no other action will be executed",
-  gst_validate_add_action_type ("wait", _execute_wait, wait_mandatory_fields,
+          .mandatory = TRUE,
+          NULL},
+        {NULL}
+      },
       "Waits during 'duration' seconds", FALSE);
+
   gst_validate_add_action_type ("dot-pipeline", _execute_dot_pipeline, NULL,
-      "Dots the pipeline (the 'name' property will be used in the\n"
+      "Dots the pipeline (the 'name' property will be used in the dot filename).\n"
-      "dot filename).\n"
+      "For more information have a look at the GST_DEBUG_BIN_TO_DOT_FILE documentation.\n"
-      "For more information have a look at the GST_DEBUG_BIN_TO_DOT_FILE documentation."
       "Note that the GST_DEBUG_DUMP_DOT_DIR env variable needs to be set\n",
       FALSE);
-  gst_validate_add_action_type ("set-feature-rank", _set_rank, NULL,
+
+  gst_validate_add_action_type ("set-feature-rank", _set_rank,
+      (GstValidateActionParameter []) {
+        {
+          .name = "feature-name",
+          .description = "The name of a GstFeature",
+          .mandatory = TRUE,
+          .types = "string",
+          NULL},
+        {
+          .name = "rank",
+          .description = "The GstRank to set on @feature-name",
+          .mandatory = TRUE,
+          .types = "string, int",
+          NULL},
+        {NULL}
+      },
       "Changes the ranking of a particular plugin feature", TRUE);
+
   gst_validate_add_action_type ("set-state", _execute_set_state,
-      set_state_mandatory_fields,
+      (GstValidateActionParameter []) {
-      "Change the state of the pipeline to any GstState as a string like:\n"
+        {
-      "    * 'null'\n"
+          .name = "state",
-      "    * 'ready'\n" "    * 'paused'\n" "    * 'play'\n", FALSE);
+          .description = "A GstState as a string, should be in: \n"
+                         "    * ['null', 'ready', 'paused', 'playing']",
+          .mandatory = TRUE,
+          .types = "string",
+        },
+        {NULL}
+      },
+      "Changes the state of the pipeline to any GstState", FALSE);
+
   gst_validate_add_action_type ("set-property", _execute_set_property,
-      set_property_mandatory_fields,
+      (GstValidateActionParameter []) {
+        {
+          .name = "target-element-name",
+          .description = "The name of the GstElement to set a property on",
+          .mandatory = TRUE,
+          .types = "string",
+          NULL},
+        {
+          .name = "property-name",
+          .description = "The name of the property to set on @target-element-name",
+          .mandatory = TRUE,
+          .types = "string",
+          NULL
+        },
+        {
+          .name = "property-value",
+          .description = "The value of @property-name to be set on the element",
+          .mandatory = TRUE,
+          .types = "The same type of @property-name",
+          NULL
+        },
+        {NULL}
+      },
       "Sets a property of any element in the pipeline", FALSE);
+
   gst_validate_add_action_type ("set-debug-threshold",
-      _execute_set_debug_threshold, set_debug_threshold_mandatory_fields,
+      _execute_set_debug_threshold,
+      (GstValidateActionParameter [])
+        {
+          {
+            .name = "debug-threshold",
+            .description = "String defining debug threshold\n"
+                           "See gst_debug_set_threshold_from_string",
+            .mandatory = TRUE,
+            .types = "string"},
+          {NULL}
+        },
       "Sets the debug level to be used, same format as\n"
       "setting the GST_DEBUG env variable", FALSE);
+
   gst_validate_add_action_type ("emit-signal", _execute_emit_signal,
-      emit_signal_mandatory_fields,
+      (GstValidateActionParameter [])
-      "Allows to emit a signal to an element in the pipeline", FALSE);
+      {
+        {
+          .name = "target-element-name",
+          .description = "The name of the GstElement to emit a signal on",
+          .mandatory = TRUE,
+          .types = "string"
+        },
+        {
+          .name = "signal-name",
+          .description = "The name of the signal to emit on @target-element-name",
+          .mandatory = TRUE,
+          .types = "string",
+          NULL
+        },
+        {NULL}
+      },
+      "Emits a signal to an element in the pipeline", FALSE);
+  /*  *INDENT-ON* */
+
 }

validate/gst/validate/gst-validate-scenario.h

@@ -41,6 +41,7 @@ typedef struct _GstValidateScenarioClass   GstValidateScenarioClass;
 typedef struct _GstValidateScenarioPrivate GstValidateScenarioPrivate;
 typedef struct _GstValidateAction          GstValidateAction;
 typedef struct _GstValidateActionType      GstValidateActionType;
+typedef struct _GstValidateActionParameter GstValidateActionParameter;
 
 typedef gboolean (*GstValidateExecuteAction) (GstValidateScenario * scenario, GstValidateAction * action);
 
@@ -72,6 +73,19 @@ GType gst_validate_action_type_get_type     (void);
 
 gboolean gst_validate_print_action_types    (gchar ** wanted_types, gint num_wanted_types);
 
+struct _GstValidateActionParameter
+{
+  const gchar  *name;
+  const gchar  *description;
+  gboolean     mandatory;
+  const gchar  *types;
+  const gchar  *possible_variables;
+  const gchar  *def;
+
+  /*< private >*/
+  gpointer     _gst_reserved[GST_PADDING];
+};
+
 struct _GstValidateScenarioClass
 {
   GObjectClass parent_class;
@@ -100,8 +114,9 @@ gst_validate_list_scenarios       (gchar **scenarios,
                                    gchar * output_file);
 
 void gst_validate_add_action_type (const gchar *type_name, GstValidateExecuteAction function,
-                                   const gchar * const * mandatory_fields, const gchar *description,
+                                   GstValidateActionParameter * parameters,
-                                   gboolean is_config);
+                                   const gchar *description, gboolean is_config);
+
 
 gboolean gst_validate_action_get_clocktime (GstValidateScenario * scenario,
                                             GstValidateAction *action,

validate/tools/gst-validate-transcoding.c

@@ -701,17 +701,60 @@ _parse_encoding_profile (const gchar * option_name, const gchar * value,
 static void
 _register_actions (void)
 {
-  const gchar *resize_video_mandatory_fields[] = { "restriction-caps", NULL };
+/* *INDENT-OFF* */
-  const gchar *force_key_unit_mandatory_fields[] = { "direction",
-    "running-time", "all-headers", "count", NULL
-  };
-
   gst_validate_add_action_type ("set-restriction", _execute_set_restriction,
-      resize_video_mandatory_fields, "Change the restriction caps on the fly",
+      (GstValidateActionParameter []) {
+        {
+          .name = "restriction-caps",
+          .description = "The restriction caps to set on the encodebin"
+                         "encoding profile.\nSee gst_encoding_profile_set_restriction()",
+          .mandatory = TRUE,
+          .types = "GstCaps serialized as a string"
+        },
+        {NULL}
+      },
+      "Change the restriction caps on the fly",
       FALSE);
   gst_validate_add_action_type ("video-request-key-unit",
-      _execute_request_key_unit, force_key_unit_mandatory_fields,
+      _execute_request_key_unit,
+      (GstValidateActionParameter []) {
+        {
+          .name = "direction",
+          .description = "The direction for the event to travel, should be in\n"
+                          "  * [upstream, downstream]",
+          .mandatory = TRUE,
+          .types = "string",
+          NULL
+        },
+        {
+          .name = "running-time",
+          .description = "The running_time can be set to request a new key unit at a specific running_time.\n"
+                          "If not set, GST_CLOCK_TIME_NONE will be used so upstream elements will produce a new key unit"
+                          "as soon as possible.",
+          .mandatory = FALSE,
+          .types = "double or string",
+          .possible_variables = "position: The current position in the stream\n"
+            "duration: The duration of the stream",
+          NULL
+        },
+        {
+          .name = "all-headers",
+          .description = "TRUE to produce headers when starting a new key unit",
+          .mandatory = TRUE,
+          .types = "boolean",
+          NULL
+        },
+        {
+          .name = "count",
+          .description = "integer that can be used to number key units",
+          .mandatory = TRUE,
+          .types = "int",
+          NULL
+        },
+        {NULL}
+      },
       "Request a video key unit", FALSE);
+/* *INDENT-ON* */
 }
 
 int

validate/tools/gst-validate.c

@@ -305,10 +305,15 @@ _register_playbin_actions (void)
 {
 /* *INDENT-OFF* */
   gst_validate_add_action_type ("set-subtitle", _execute_set_subtitles,
-      (GstValidateActionParameter [])
+      (GstValidateActionParameter []) {
-      {
+        {
-        {"subtitle-file", "", TRUE}
+          .name = "subtitle-file",
-        , {NULL}
+          .description = "Sets a subtitles file on a playbin pipeline",
+          .mandatory = TRUE,
+          .types = "string (A URI)",
+          NULL
+        },
+        {NULL}
       },
       "Action to set a subtitle file to use on a playbin pipeline.\n"
       "The subtitles file that will be used should will be specified\n"