mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-22 23:28:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtcbin: Fix race bringing up sctp data channel

Browse source 
Notifying before pads are linked can cause the stream to fail to start.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2256>
This commit is contained in:
Doug Nazar 2021-05-17 09:11:54 -04:00 committed by GStreamer Marge Bot
parent a836bd4766
commit 4fcfd5b7f9
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ext/webrtc/webrtcdatachannel.c
View file

@ -1020,7 +1020,6 @@ _data_channel_set_sctp_transport (WebRTCDataChannel * channel,
channel);
g_signal_connect (sctp, "notify::state", G_CALLBACK (_on_sctp_notify_state),
channel);
_on_sctp_notify_state_unlocked (G_OBJECT (sctp), channel);
}
GST_WEBRTC_DATA_CHANNEL_UNLOCK (channel);
}
@ -1043,6 +1042,8 @@ webrtc_data_channel_link_to_sctp (WebRTCDataChannel * channel,
channel->sctp_transport->sctpenc, pad_name))
g_warn_if_reached ();
g_free (pad_name);
_on_sctp_notify_state_unlocked (G_OBJECT (sctp_transport), channel);
}
}
}