mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-10 19:31:12 +00:00
Code Issues 1 Projects Releases Wiki Activity

lame: Avoid crash when seeking before negotiating

Browse source 
lame's 'lgv' variable is only initialized when the caps
is negotiated, whenever a seek happens before that, it would
attempt to call a function on an empty pointer, causing the crash.

Fixes #603515
This commit is contained in:
Thiago Santos 2009-12-02 11:21:22 -03:00
parent 98acc9703b
commit 4f7d1a2ed5
2 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ext/lame/gstlame.c
View file

@ -1024,11 +1024,13 @@ gst_lame_sink_event (GstPad * pad, GstEvent * event)
GST_DEBUG_OBJECT (lame, "handling FLUSH stop event");
/* clear buffers */
mp3_buffer_size = 7200;
mp3_data = g_malloc (mp3_buffer_size);
lame_encode_flush (lame->lgf, mp3_data, mp3_buffer_size);
g_free (mp3_data);
if (lame->lgf) {
/* clear buffers if we already have lame set up */
mp3_buffer_size = 7200;
mp3_data = g_malloc (mp3_buffer_size);
lame_encode_flush (lame->lgf, mp3_data, mp3_buffer_size);
g_free (mp3_data);
}
ret = gst_pad_push_event (lame->srcpad, event);
break;

12
ext/lame/gstlamemp3enc.c
View file

@ -586,11 +586,13 @@ gst_lamemp3enc_sink_event (GstPad * pad, GstEvent * event)
GST_DEBUG_OBJECT (lame, "handling FLUSH stop event");
/* clear buffers */
mp3_buffer_size = 7200;
mp3_data = g_malloc (mp3_buffer_size);
lame_encode_flush (lame->lgf, mp3_data, mp3_buffer_size);
g_free (mp3_data);
if (lame->lgf) {
/* clear buffers if we already have lame set up */
mp3_buffer_size = 7200;
mp3_data = g_malloc (mp3_buffer_size);
lame_encode_flush (lame->lgf, mp3_data, mp3_buffer_size);
g_free (mp3_data);
}
ret = gst_pad_push_event (lame->srcpad, event);
break;