mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-17 12:55:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

validate: report: avoid pointless var & associated dup/free

Browse source 
Just pass the replacement string literal to _regex_replace().
This commit is contained in:
Reynaldo H. Verdejo Pinochet 2017-04-05 14:40:12 -07:00
parent 38440a5931
commit 4ec6bda043
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
validate/gst/validate/gst-validate-report.c
View file

@ -868,7 +868,7 @@ gst_validate_printf_valist (gpointer source, const gchar * format, va_list args)
} else if (*(GType *) source == GST_TYPE_VALIDATE_ACTION_TYPE) { } else if (*(GType *) source == GST_TYPE_VALIDATE_ACTION_TYPE) {
gint i; gint i;
gchar *desc, *tmp; gchar *desc;
gboolean has_parameters = FALSE; gboolean has_parameters = FALSE;
GstValidateActionParameter playback_time_param = { GstValidateActionParameter playback_time_param = {
@ -896,13 +896,10 @@ gst_validate_printf_valist (gpointer source, const gchar * format, va_list args)
"at the beginning of the execution of the pipeline)"); "at the beginning of the execution of the pipeline)");
tmp = g_strdup_printf ("\n "); desc = g_regex_replace (newline_regex, type->description, -1, 0, "\n ",
desc = 0, NULL);
g_regex_replace (newline_regex, type->description, -1, 0, tmp, 0,
NULL);
g_string_append_printf (string, "\n\n Description: \n %s", desc); g_string_append_printf (string, "\n\n Description: \n %s", desc);
g_free (desc); g_free (desc);
g_free (tmp);
if (!IS_CONFIG_ACTION_TYPE (type->flags)) if (!IS_CONFIG_ACTION_TYPE (type->flags))
print_action_parameter (string, type, &playback_time_param); print_action_parameter (string, type, &playback_time_param);