mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-09-27 14:31:01 +00:00
Code Issues 1 Projects Releases Wiki Activity

glbasesrc: Reverse order of error/debug messages

Browse source 
Addressing follow-up review from Tim in !4222, the first string is meant to be
shown to the user and should be translatable. The second one is more suited for
debugging purposes and should not be translated.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4389>
This commit is contained in:
Philippe Normand 2023-04-11 11:48:09 +01:00
parent da4aa00d5b
commit 4e4cb3bcf5
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
subprojects/gst-plugins-base/gst-libs/gst/gl/gstglbasesrc.c
View file

@ -444,14 +444,14 @@ gl_error:
{
g_rec_mutex_unlock (&src->priv->context_lock);
GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND,
(_("failed to fill GL memory")), (_("A GL error occurred")));
(_("An OpenGL error occurred")), ("failed to fill GL memory"));
return GST_FLOW_NOT_NEGOTIATED;
}
not_negotiated:
{
g_rec_mutex_unlock (&src->priv->context_lock);
GST_ELEMENT_ERROR (src, CORE, NEGOTIATION, (NULL),
(_("format wasn't negotiated before get function")));
("format wasn't negotiated before get function"));
return GST_FLOW_NOT_NEGOTIATED;
}
eos:
@ -586,8 +586,9 @@ unsupported_gl_api:
gchar *supported_gl_api_str =
gst_gl_api_to_string (klass->supported_gl_api);
GST_ELEMENT_ERROR (src, RESOURCE, BUSY,
("GL API's not compatible context: %s supported: %s", gl_api_str,
supported_gl_api_str), (NULL));
(_("The GL API is not compatible with the current GL context")),
("Current GL API is %s, supported APIs: %s", gl_api_str,
supported_gl_api_str));
g_free (supported_gl_api_str);
g_free (gl_api_str);
@ -610,7 +611,7 @@ context_error:
error:
{
GST_ELEMENT_ERROR (src, LIBRARY, INIT,
("Subclass failed to initialize."), (NULL));
(_("Subclass failed to initialize.")), (NULL));
return FALSE;
}
}