mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

wrappercamerabinsrc: Avoid fixating capture caps

Browse source 
When setting the internal capsfilter caps for capture we should put
the full caps instead of trying to fixate it ourselves. This way we let
the elements (and mostly the source) select the best format instead
of defaulting to what the pad fixation function picks.
This commit is contained in:
Thiago Santos 2011-02-09 19:09:24 -03:00
parent ce45c15200
commit 4da517ae87
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gst/camerabin2/gstwrappercamerabinsrc.c
View file

@ -605,9 +605,6 @@ start_image_capture (GstWrapperCameraBinSrc * self)
caps = gst_pad_get_allowed_caps (self->imgsrc); caps = gst_pad_get_allowed_caps (self->imgsrc);
caps = gst_caps_make_writable (caps);
gst_pad_fixate_caps (self->imgsrc, caps);
gst_caps_replace (&self->image_capture_caps, caps); gst_caps_replace (&self->image_capture_caps, caps);
gst_caps_unref (caps); gst_caps_unref (caps);
@ -942,10 +939,9 @@ gst_wrapper_camera_bin_src_start_capture (GstBaseCameraSrc * camerasrc)
if (src->src_zoom_filter) if (src->src_zoom_filter)
g_object_set (src->src_zoom_filter, "caps", NULL, NULL); g_object_set (src->src_zoom_filter, "caps", NULL, NULL);
GST_DEBUG_OBJECT (src, "Getting allowed videosrc caps");
caps = gst_pad_get_allowed_caps (src->vidsrc); caps = gst_pad_get_allowed_caps (src->vidsrc);
caps = gst_caps_make_writable (caps); GST_DEBUG_OBJECT (src, "Video src caps %" GST_PTR_FORMAT, caps);
gst_pad_fixate_caps (src->vidsrc, caps);
GST_DEBUG_OBJECT (src, "Vidsrc caps fixated to %" GST_PTR_FORMAT, caps);
src->video_renegotiate = FALSE; src->video_renegotiate = FALSE;
g_mutex_unlock (camerasrc->capturing_mutex); g_mutex_unlock (camerasrc->capturing_mutex);